staging: kpc2000: kpc_spi: use devm_* API to manage mapped I/O space
authorGeordan Neukum <gneukum1@gmail.com>
Sun, 2 Jun 2019 15:58:37 +0000 (15:58 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 Jun 2019 12:17:01 +0000 (14:17 +0200)
The kpc_spi driver does not unmap its I/O space upon error cases in the
probe() function or upon remove(). Make the driver clean up after itself
more maintainably by migrating to using the managed resource API.

Signed-off-by: Geordan Neukum <gneukum1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/kpc2000/kpc2000_spi.c

index b513432..32d3ec5 100644 (file)
@@ -471,7 +471,8 @@ kp_spi_probe(struct platform_device *pldev)
                goto free_master;
        }
 
-       kpspi->phys = (unsigned long)ioremap_nocache(r->start, resource_size(r));
+       kpspi->phys = (unsigned long)devm_ioremap_nocache(&pldev->dev, r->start,
+                                                         resource_size(r));
        kpspi->base = (u64 __iomem *)kpspi->phys;
 
        status = spi_register_master(master);