return doAOTList(dllList, refPaths, opt);
}
-// callback function of "pkgmgrinfo_appinfo_metadata_filter_foreach"
-static int appAotCb(pkgmgrinfo_appinfo_h handle, void *userData)
+static ni_error_e removeAndCreateNI(const char* pkgId, NIOption* pOptions)
+{
+ if (removeNIUnderPkgRoot(pkgId) != NI_ERROR_NONE) {
+ _SERR("Failed to remove previous dlls from [%s]", pkgId);
+ return NI_ERROR_UNKNOWN;
+ }
+
+ if (createNIUnderPkgRoot(pkgId, pOptions) != NI_ERROR_NONE) {
+ _SERR("Failed to generate NI file [%s]", pkgId);
+ return NI_ERROR_UNKNOWN;
+ } else {
+ _SOUT("Complete make native image for pkg (%s)", pkgId);
+ }
+
+ return NI_ERROR_NONE;
+}
+
+static bool isReadOnlyPkg(std::string pkgId)
{
- char *pkgId = NULL;
int ret = 0;
- NIOption **pOptions = (NIOption**)userData;
-
- if ((*pOptions)->flags & NI_FLAGS_SKIP_RO_APP) {
- bool isSystem = false;
- int ret = pkgmgrinfo_appinfo_is_system(handle, &isSystem);
- if (ret != PMINFO_R_OK) {
- _SERR("Failed to check that app is System or not\n");
- return -1;
- }
- if (isSystem) {
- return 0;
- }
+ bool readonly = false;
+ pkgmgrinfo_pkginfo_h handle;
+
+ ret = pkgmgrinfo_pkginfo_get_pkginfo(pkgId.c_str(), &handle);
+ if (ret != PMINFO_R_OK) {
+ _ERR("Fail to get pkginfo");
+ return false;
}
- ret = pkgmgrinfo_appinfo_get_pkgid(handle, &pkgId);
+ ret = pkgmgrinfo_pkginfo_is_readonly(handle, &readonly);
if (ret != PMINFO_R_OK) {
- _SERR("Failed to get pkgid");
- return -1;
+ _ERR("Fail to get is_readonly");
+ pkgmgrinfo_pkginfo_destroy_pkginfo(handle);
+ return false;
}
- if (removeNIUnderPkgRoot(pkgId) != NI_ERROR_NONE) {
- _SERR("Failed to remove previous dlls from [%s]", pkgId);
+ pkgmgrinfo_pkginfo_destroy_pkginfo(handle);
+ return readonly;
+}
+
+// callback function of "pkgmgrinfo_appinfo_metadata_filter_foreach"
+static int appAotCb(pkgmgrinfo_appinfo_h handle, void *userData)
+{
+ char *pkgId = NULL;
+ int ret = pkgmgrinfo_appinfo_get_pkgid(handle, &pkgId);
+ if (ret != PMINFO_R_OK) {
+ _SERR("Failed to get pkgid");
return -1;
}
- if (createNIUnderPkgRoot(pkgId, *pOptions) != NI_ERROR_NONE) {
- _SERR("Failed to generate NI file [%s]", pkgId);
+ std::vector<std::string> *pkgList = (std::vector<std::string> *)userData;
+ pkgList->push_back(pkgId);
+
+ return 0;
+}
+
+// callback function of "pkgmgrinfo_pkginfo_metadata_filter_foreach"
+static int pkgAotCb(pkgmgrinfo_pkginfo_h handle, void *userData)
+{
+ char *pkgId = NULL;
+ int ret = pkgmgrinfo_pkginfo_get_pkgid(handle, &pkgId);
+ if (ret != PMINFO_R_OK) {
+ _SERR("Failed to get pkgid");
return -1;
- } else {
- _SOUT("Complete make application to native image");
}
+ std::vector<std::string> *pkgList = (std::vector<std::string> *)userData;
+ pkgList->push_back(pkgId);
+
return 0;
}
ni_error_e createNIUnderPkgRoot(const std::string& pkgId, NIOption* opt)
{
+ ni_error_e ret;
+
if (!isR2RImage(concatPath(__pm->getRuntimePath(), "System.Private.CoreLib.dll"))) {
_SERR("The native image of System.Private.CoreLib does not exist.\n"
"Run the command to create the native image\n"
return NI_ERROR_INVALID_PACKAGE;
}
- __pm->setAppRootPath(rootPath);
-
char* extraDllPaths = pluginGetExtraDllPath();
if (extraDllPaths && extraDllPaths[0] != '\0') {
opt->flags |= NI_FLAGS_EXTRA_REF;
splitPath(extraDllPaths, opt->extraRefPath);
}
- opt->flags |= NI_FLAGS_APPNI;
-
- if (isReadOnlyArea(rootPath)) {
- opt->flags |= NI_FLAGS_APP_UNDER_RO_AREA;
- opt->flags |= NI_FLAGS_NO_PIPELINE;
- std::string tmpPath = replaceAll(rootPath, getBaseName(rootPath), __READ_ONLY_APP_UPDATE_DIR);
- if (!removeAll(tmpPath)){
- _SERR("Fail to remove RO App update path : %s", tmpPath.c_str());
+ if (isRPK(pkgId)) {
+ opt->flags &= ~NI_FLAGS_APPNI;
+ std::string paths = getResourcePaths(rootPath);
+ if (!paths.empty()) {
+ ret = createNIUnderDirs(paths, opt);
+ } else {
+ _SERR("Failed to get rpk paths from [%s]", pkgId.c_str());
+ ret = NI_ERROR_UNKNOWN;
}
- _SERR("Only no-pipeline mode supported for RO app. Set no-pipeline option forcibly");
} else {
- opt->flags &= ~NI_FLAGS_APP_UNDER_RO_AREA;
+ __pm->setAppRootPath(rootPath);
+
+ opt->flags |= NI_FLAGS_APPNI;
+
+ if (isReadOnlyArea(rootPath)) {
+ opt->flags |= NI_FLAGS_APP_UNDER_RO_AREA;
+ opt->flags |= NI_FLAGS_NO_PIPELINE;
+ _SERR("Only no-pipeline mode supported for RO app. Set no-pipeline option forcibly");
+ } else {
+ opt->flags &= ~NI_FLAGS_APP_UNDER_RO_AREA;
+ }
+
+ // create native image under bin and lib directory
+ // tac directory is skipped in the createNIUnderDirs.
+ ret = createNIUnderDirs(__pm->getAppPaths(), opt);
}
- // create native image under bin and lib directory
- // tac directory is skipped in the createNIUnderDirs.
- return createNIUnderDirs(__pm->getAppPaths(), opt);
+ return ret;
}
void removeNIPlatform()
ni_error_e removeNIUnderPkgRoot(const std::string& pkgId)
{
+ std::vector<std::string> paths;
+
std::string rootPath = getRootPath(pkgId);
if (rootPath.empty()) {
_SERR("Failed to get root path from [%s]", pkgId.c_str());
return NI_ERROR_INVALID_PACKAGE;
}
- __pm->setAppRootPath(rootPath);
-
- // getAppNIPaths returns bin/.native_image, lib/.native_image and .tac_symlink.
- std::string appNIPaths = __pm->getAppNIPaths();
- std::vector<std::string> paths;
- splitPath(appNIPaths, paths);
- for (const auto &path : paths) {
- if (!isReadOnlyArea(path)) {
- // Only the native image inside the TAC should be removed.
- if (strstr(path.c_str(), TAC_SYMLINK_SUB_DIR) != NULL) {
+ if (isRPK(pkgId)) {
+ std::string rpkPaths = getResourcePaths(rootPath);
+ if (rpkPaths.empty()) {
+ _SERR("Failed to get rpk path from [%s]", pkgId.c_str());
+ return NI_ERROR_UNKNOWN;
+ }
+ splitPath(rpkPaths, paths);
+ for (const auto &path : paths) {
+ if (isDirectory(path)) {
removeNIUnderDirs(path);
- } else {
- if (isDirectory(path)) {
- if (!removeAll(path.c_str())) {
- _SERR("Failed to remove app ni dir [%s]", path.c_str());
+ }
+ }
+ } else {
+ __pm->setAppRootPath(rootPath);
+
+ // getAppNIPaths returns bin/.native_image, lib/.native_image and .tac_symlink.
+ std::string appNIPaths = __pm->getAppNIPaths();
+ splitPath(appNIPaths, paths);
+ for (const auto &path : paths) {
+ if (!isReadOnlyArea(path)) {
+ // Only the native image inside the TAC should be removed.
+ if (strstr(path.c_str(), TAC_SYMLINK_SUB_DIR) != NULL) {
+ removeNIUnderDirs(path);
+ } else {
+ if (isDirectory(path)) {
+ if (!removeAll(path.c_str())) {
+ _SERR("Failed to remove app ni dir [%s]", path.c_str());
+ }
}
}
}
}
- }
- // In special cases, the ni file may exist in the dll location.
- // The code below is to avoid this exceptional case.
- std::string appPaths = __pm->getAppPaths();
- splitPath(appPaths, paths);
- for (const auto &path : paths) {
- if (isDirectory(path)) {
- removeNIUnderDirs(path);
+ // In special cases, the ni file may exist in the dll location.
+ // The code below is to avoid this exceptional case.
+ std::string appPaths = __pm->getAppPaths();
+ splitPath(appPaths, paths);
+ for (const auto &path : paths) {
+ if (isDirectory(path)) {
+ removeNIUnderDirs(path);
+ }
}
}
return NI_ERROR_NONE;
}
-ni_error_e regenerateAppNI(NIOption* opt)
+ni_error_e regeneratePkgNI(NIOption* opt)
{
- int ret = 0;
- pkgmgrinfo_appinfo_metadata_filter_h handle;
+ std::vector<std::string> pkgList;
+ ni_error_e ret = NI_ERROR_NONE;
- ret = pkgmgrinfo_appinfo_metadata_filter_create(&handle);
- if (ret != PMINFO_R_OK)
- return NI_ERROR_UNKNOWN;
+ // iterates for Packages's metadata (RPK)
+ pkgmgrinfo_pkginfo_metadata_filter_h pkgHandle;
+ if (pkgmgrinfo_pkginfo_metadata_filter_create(&pkgHandle) == PMINFO_R_OK) {
+ if (pkgmgrinfo_pkginfo_metadata_filter_add(pkgHandle, AOT_METADATA_KEY, METADATA_VALUE_TRUE) == PMINFO_R_OK) {
+ if (pkgmgrPkgMDFilterForeach(pkgHandle, pkgAotCb, &pkgList) != 0) {
+ ret = NI_ERROR_UNKNOWN;
+ _ERR("pkgmgrPkgMDFilterForeach failed");
+ }
+ } else {
+ ret = NI_ERROR_UNKNOWN;
+ _ERR("pkgmgrinfo_pkginfo_metadata_filter_add failed");
+ }
+ pkgmgrinfo_pkginfo_metadata_filter_destroy(pkgHandle);
+ } else {
+ ret = NI_ERROR_UNKNOWN;
+ _ERR("pkgmgrinfo_pkginfo_metadata_filter_create failed");
+ }
- ret = pkgmgrinfo_appinfo_metadata_filter_add(handle, AOT_METADATA_KEY, METADATA_VALUE_TRUE);
- if (ret != PMINFO_R_OK) {
- pkgmgrinfo_appinfo_metadata_filter_destroy(handle);
- return NI_ERROR_UNKNOWN;
+ // iterate for App's metadata
+ pkgmgrinfo_appinfo_metadata_filter_h appHandle;
+ if (pkgmgrinfo_appinfo_metadata_filter_create(&appHandle) == PMINFO_R_OK) {
+ if (pkgmgrinfo_appinfo_metadata_filter_add(appHandle, AOT_METADATA_KEY, METADATA_VALUE_TRUE) == PMINFO_R_OK) {
+ if (pkgmgrAppMDFilterForeach(appHandle, appAotCb, &pkgList) != 0) {
+ ret = NI_ERROR_UNKNOWN;
+ _ERR("pkgmgrAppMDFilterForeach failed");
+ }
+ } else {
+ ret = NI_ERROR_UNKNOWN;
+ _ERR("pkgmgrinfo_appinfo_metadata_filter_add failed");
+ }
+ pkgmgrinfo_appinfo_metadata_filter_destroy(appHandle);
+ } else {
+ ret = NI_ERROR_UNKNOWN;
+ _ERR("pkgmgrinfo_appinfo_metadata_filter_create failed");
}
- ret = pkgmgrMDFilterForeach(handle, appAotCb, &opt);
- if (ret != 0) {
- pkgmgrinfo_appinfo_metadata_filter_destroy(handle);
- return NI_ERROR_UNKNOWN;
+ // remove duplicated pkg in the list.
+ // If one package has multiple apps, there can be duplicate values.
+ std::sort(pkgList.begin(), pkgList.end());
+ pkgList.erase(unique(pkgList.begin(), pkgList.end()), pkgList.end());
+
+ for (auto pkg : pkgList) {
+ if (isReadOnlyPkg(pkg) && opt->flags & NI_FLAGS_SKIP_RO_APP) {
+ continue;
+ }
+
+ if (removeAndCreateNI(pkg.c_str(), opt) != NI_ERROR_NONE) {
+ _SERR("Failed to remove previous dlls from [%s]", pkg.c_str());
+ ret = NI_ERROR_UNKNOWN;
+ } else {
+ _SOUT("Complete make application to native image");
+ }
}
- pkgmgrinfo_appinfo_metadata_filter_destroy(handle);
- return NI_ERROR_NONE;
+ return ret;
}
// callback function of "pkgmgrinfo_appinfo_metadata_filter_foreach"
return NI_ERROR_UNKNOWN;
}
- ret = pkgmgrMDFilterForeach(handle, regenTacCb, &opt);
+ ret = pkgmgrAppMDFilterForeach(handle, regenTacCb, &opt);
if (ret != 0) {
pkgmgrinfo_appinfo_metadata_filter_destroy(handle);
return NI_ERROR_UNKNOWN;
projects / platform / core / dotnet / launcher.git / commitdiff