wifi: rtw89: refine leaving LPS function
authorZong-Zhe Yang <kevin_yang@realtek.com>
Tue, 2 Aug 2022 12:37:12 +0000 (20:37 +0800)
committerKalle Valo <kvalo@kernel.org>
Tue, 9 Aug 2022 06:00:44 +0000 (09:00 +0300)
It's unnecessary to iterate leaving PS mode.
So, move it out of the iteration.

Signed-off-by: Zong-Zhe Yang <kevin_yang@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20220802123712.16577-1-pkshih@realtek.com
drivers/net/wireless/realtek/rtw89/ps.c

index a90b337..ea32601 100644 (file)
@@ -127,7 +127,6 @@ static void rtw89_leave_lps_vif(struct rtw89_dev *rtwdev, struct rtw89_vif *rtwv
        if (rtwvif->wifi_role != RTW89_WIFI_ROLE_STATION)
                return;
 
-       __rtw89_leave_ps_mode(rtwdev);
        __rtw89_leave_lps(rtwdev, rtwvif->mac_id);
 }
 
@@ -140,6 +139,8 @@ void rtw89_leave_lps(struct rtw89_dev *rtwdev)
        if (!test_and_clear_bit(RTW89_FLAG_LEISURE_PS, rtwdev->flags))
                return;
 
+       __rtw89_leave_ps_mode(rtwdev);
+
        rtw89_for_each_rtwvif(rtwdev, rtwvif)
                rtw89_leave_lps_vif(rtwdev, rtwvif);
 }