amt: remove unnecessary skb pointer check
authorYang Yingliang <yangyingliang@huawei.com>
Thu, 18 Aug 2022 09:31:14 +0000 (17:31 +0800)
committerJakub Kicinski <kuba@kernel.org>
Fri, 19 Aug 2022 23:51:21 +0000 (16:51 -0700)
The skb pointer will be checked in kfree_skb(), so remove the outside check.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Taehee Yoo <ap420073@gmail.com>
Link: https://lore.kernel.org/r/20220818093114.2449179-1-yangyingliang@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/amt.c

index 9a247eb..2d20be6 100644 (file)
@@ -2894,8 +2894,7 @@ static void amt_event_work(struct work_struct *work)
                        amt_event_send_request(amt);
                        break;
                default:
-                       if (skb)
-                               kfree_skb(skb);
+                       kfree_skb(skb);
                        break;
                }
        }
@@ -3033,8 +3032,7 @@ static int amt_dev_stop(struct net_device *dev)
        cancel_work_sync(&amt->event_wq);
        for (i = 0; i < AMT_MAX_EVENTS; i++) {
                skb = amt->events[i].skb;
-               if (skb)
-                       kfree_skb(skb);
+               kfree_skb(skb);
                amt->events[i].event = AMT_EVENT_NONE;
                amt->events[i].skb = NULL;
        }