Use std::make_unique instead of `new` to reinitalize a unique_ptr (NFC)
authorMehdi Amini <joker.eph@gmail.com>
Sun, 14 Nov 2021 22:28:54 +0000 (22:28 +0000)
committerMehdi Amini <joker.eph@gmail.com>
Sun, 14 Nov 2021 22:28:54 +0000 (22:28 +0000)
Fix a clang-tidy warning.

mlir/lib/Pass/Pass.cpp

index 9d0a0c1..f8551fc 100644 (file)
@@ -226,7 +226,7 @@ OpPassManager::OpPassManager(StringRef name, Nesting nesting)
 OpPassManager::OpPassManager(OpPassManager &&rhs) : impl(std::move(rhs.impl)) {}
 OpPassManager::OpPassManager(const OpPassManager &rhs) { *this = rhs; }
 OpPassManager &OpPassManager::operator=(const OpPassManager &rhs) {
-  impl.reset(new OpPassManagerImpl(rhs.impl->name, rhs.impl->nesting));
+  impl = std::make_unique<OpPassManagerImpl>(rhs.impl->name, rhs.impl->nesting);
   impl->initializationGeneration = rhs.impl->initializationGeneration;
   for (auto &pass : rhs.impl->passes) {
     auto newPass = pass->clone();