media: atomisp: Fix runtime PM imbalance in atomisp_pci_probe
authorDinghao Liu <dinghao.liu@zju.edu.cn>
Thu, 8 Apr 2021 08:18:43 +0000 (10:18 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 22 Jul 2021 12:01:55 +0000 (14:01 +0200)
When hmm_pool_register() fails, a pairing PM usage counter
increment is needed to keep the counter balanced. It's the
same for the following error paths.

Link: https://lore.kernel.org/linux-media/20210408081850.24278-1-dinghao.liu@zju.edu.cn
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/atomisp/pci/atomisp_v4l2.c

index 948769c..af0d83e 100644 (file)
@@ -1815,6 +1815,7 @@ request_irq_fail:
        hmm_cleanup();
        hmm_pool_unregister(HMM_POOL_TYPE_RESERVED);
 hmm_pool_fail:
+       pm_runtime_get_noresume(&pdev->dev);
        destroy_workqueue(isp->wdt_work_queue);
 wdt_work_queue_fail:
        atomisp_acc_cleanup(isp);