Fix coverity issue of OVERRUN and UNUSED_VALUE 14/291314/1
authorYoungHun Kim <yh8004.kim@samsung.com>
Thu, 13 Apr 2023 06:21:39 +0000 (15:21 +0900)
committerYoungHun Kim <yh8004.kim@samsung.com>
Thu, 13 Apr 2023 07:36:13 +0000 (07:36 +0000)
Change-Id: I62c2a7a4c46bd5fb77fef1b89dd7731ea2013c05

core/src/muse_core.c
packaging/mused.spec
server/src/muse_server_ipc.c

index af4ae9a636176cea9b7cf461002b61e333d67789..2cd55da183563166169631767c8c28dc1dcbe28d 100644 (file)
@@ -132,8 +132,15 @@ out:
 
 static gboolean _muse_msg_is_mem_ptr_valid(gpointer ptr)
 {
-       size_t page_size = sysconf(_SC_PAGESIZE);
-       gpointer base = (gpointer)((size_t)ptr / page_size * page_size);
+       gpointer base;
+       long page_size = sysconf(_SC_PAGESIZE);
+
+       if (page_size < 0) {
+               LOGE("sysconf is failed errno (%d)", errno);
+               return FALSE;
+       }
+
+       base = (gpointer)((size_t)ptr / page_size * page_size);
 
        return msync(base, page_size, MS_ASYNC) == 0;
 }
index 65ea6b8c8d33b448b30618f4faad598dddd59bb2..771d87f89726f25448013d5135d56ee8e6698090 100644 (file)
@@ -1,6 +1,6 @@
 Name:       mused
 Summary:    A multimedia daemon
-Version:    0.3.166
+Version:    0.3.167
 Release:    0
 Group:      System/Libraries
 License:    Apache-2.0
index 4967b768769b9fbee12869832104cffc36cac351..18844cff0b53f2eafcc3651da7ba7aae59fa6549 100644 (file)
@@ -302,7 +302,6 @@ static gpointer _ms_ipc_dispatch_worker(gpointer data)
                                }
                        }
                        muse_core_msg_object_free(jobj);
-                       jobj = NULL;
                        m->msg_offset += parse_len;
                        parse_len = len - parse_len;
                }