drm/nouveau/fifo: return ERR_PTR from nvkm_runl_new()

Callers expect this - not NULL.

Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Reviewed-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Karol Herbst <kherbst@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230525003106.3853741-6-skeggsb@gmail.com

diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c
index 93d628d7d508b66824d6d75190b7c1349cbcd6c0..454a481a0aef3edb5a5b4656683abde466eb77be 100644 (file)
--- a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c
@@ -399,7 +399,7 @@ nvkm_runl_new(struct nvkm_fifo *fifo, int runi, u32 addr, int id_nr)
        int ret;
 
        if (!(runl = kzalloc(sizeof(*runl), GFP_KERNEL)))
-               return NULL;
+               return ERR_PTR(-ENOMEM);
 
        runl->func = fifo->func->runl;
        runl->fifo = fifo;
@@ -419,7 +419,7 @@ nvkm_runl_new(struct nvkm_fifo *fifo, int runi, u32 addr, int id_nr)
                    (ret = nvkm_chid_new(&nvkm_chan_event, subdev, id_nr, 0, id_nr, &runl->chid))) {
                        RUNL_ERROR(runl, "cgid/chid: %d", ret);
                        nvkm_runl_del(runl);
-                       return NULL;
+                       return ERR_PTR(ret);
                }
        } else {
                runl->cgid = nvkm_chid_ref(fifo->cgid);