HID: fix memdup.cocci warnings

drivers/hid/hid-thrustmaster.c:300:27-34: WARNING opportunity for kmemdup

 Use kmemdup rather than duplicating its implementation

Generated by: scripts/coccinelle/api/memdup.cocci

Fixes: c49c33637802 ("HID: support for initialization of some Thrustmaster wheels")
CC: Dario Pagani <dario.pagani.146@gmail.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

diff --git a/drivers/hid/hid-thrustmaster.c b/drivers/hid/hid-thrustmaster.c
index bfcd087..d38304a 100644 (file)
--- a/drivers/hid/hid-thrustmaster.c
+++ b/drivers/hid/hid-thrustmaster.c
@@ -297,12 +297,13 @@ static int thrustmaster_probe(struct hid_device *hdev, const struct hid_device_i
                goto error2;
        }
 
-       tm_wheel->model_request = kzalloc(sizeof(struct usb_ctrlrequest), GFP_KERNEL);
+       tm_wheel->model_request = kmemdup(&model_request,
+                                         sizeof(struct usb_ctrlrequest),
+                                         GFP_KERNEL);
        if (!tm_wheel->model_request) {
                ret = -ENOMEM;
                goto error3;
        }
-       memcpy(tm_wheel->model_request, &model_request, sizeof(struct usb_ctrlrequest));
 
        tm_wheel->response = kzalloc(sizeof(struct tm_wheel_response), GFP_KERNEL);
        if (!tm_wheel->response) {