Fix test failure with old Copy-On-Write std::string
authorJonathan Wakely <jwakely@redhat.com>
Fri, 4 Jan 2019 15:42:33 +0000 (15:42 +0000)
committerJonathan Wakely <redi@gcc.gnu.org>
Fri, 4 Jan 2019 15:42:33 +0000 (15:42 +0000)
* testsuite/27_io/filesystem/filesystem_error/copy.cc: Fix static
assertion failures with old std::string ABI.

From-SVN: r267577

libstdc++-v3/ChangeLog
libstdc++-v3/testsuite/27_io/filesystem/filesystem_error/copy.cc

index 499812c..00550d8 100644 (file)
@@ -1,5 +1,8 @@
 2019-01-04  Jonathan Wakely  <jwakely@redhat.com>
 
+       * testsuite/27_io/filesystem/filesystem_error/copy.cc: Fix static
+       assertion failures with old std::string ABI.
+
        * include/bits/fs_path.h (path::_List::erase): Replace both overloads
        with ...
        (path::pop_back(), path::_M_erase_from(const_iterator)): New member
index 529e1e4..71eac38 100644 (file)
 
 using std::filesystem::filesystem_error;
 
+// The COW std::string does not have noexcept copies, because copying a
+// "leaked" string can throw (and for fully-dynamic strings, copying the
+// empty rep can also throw).
+// That's OK, because we know that the std::string in the std::runtime_error
+// or std::logic_error base class won't be leaked (and usually won't be empty).
+// The is_nothrow_xxx type traits don't know that though, so we can only
+// check them for the cxx11 ABI, which uses __cow_string, which has noexcept
+// copies.
+#if _GLIBCXX_USE_CXX11_ABI
 // PR libstdc++/83306
 static_assert(std::is_nothrow_copy_constructible_v<filesystem_error>);
 static_assert(std::is_nothrow_copy_assignable_v<filesystem_error>);
+#endif
 
 void
 test01()