dpaa2-eth: Fix minor bug in ethtool stats reporting
authorIoana Radulescu <ruxandra.radulescu@nxp.com>
Mon, 7 Oct 2019 11:38:27 +0000 (14:38 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 26 Jan 2020 09:01:04 +0000 (10:01 +0100)
[ Upstream commit 4b177f065e7ec37399b18e18412a8c7b75f8f299 ]

Don't print error message for a successful return value.

Fixes: d84c3a4ded96 ("dpaa2-eth: Add new DPNI statistics counters")

Signed-off-by: Ioana Radulescu <ruxandra.radulescu@nxp.com>
Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/freescale/dpaa2/dpaa2-ethtool.c

index 0aa1c34..dc9a6c3 100644 (file)
@@ -216,7 +216,7 @@ static void dpaa2_eth_get_ethtool_stats(struct net_device *net_dev,
                if (err == -EINVAL)
                        /* Older firmware versions don't support all pages */
                        memset(&dpni_stats, 0, sizeof(dpni_stats));
-               else
+               else if (err)
                        netdev_warn(net_dev, "dpni_get_stats(%d) failed\n", j);
 
                num_cnt = dpni_stats_page_size[j] / sizeof(u64);