crypto: drbg - remove unnecessary (void*) conversions
authorDong Chuanjian <chuanjian@nfschina.com>
Thu, 11 Aug 2022 07:17:33 +0000 (15:17 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 19 Aug 2022 10:39:36 +0000 (18:39 +0800)
remove unnecessary void* type casting

v2:
Turn assignments less than 75 characters into one line.

Signed-off-by: Dong Chuanjian <chuanjian@nfschina.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/drbg.c

index 177983b..982d4ca 100644 (file)
@@ -1703,7 +1703,7 @@ static int drbg_init_hash_kernel(struct drbg_state *drbg)
 
 static int drbg_fini_hash_kernel(struct drbg_state *drbg)
 {
-       struct sdesc *sdesc = (struct sdesc *)drbg->priv_data;
+       struct sdesc *sdesc = drbg->priv_data;
        if (sdesc) {
                crypto_free_shash(sdesc->shash.tfm);
                kfree_sensitive(sdesc);
@@ -1715,7 +1715,7 @@ static int drbg_fini_hash_kernel(struct drbg_state *drbg)
 static void drbg_kcapi_hmacsetkey(struct drbg_state *drbg,
                                  const unsigned char *key)
 {
-       struct sdesc *sdesc = (struct sdesc *)drbg->priv_data;
+       struct sdesc *sdesc = drbg->priv_data;
 
        crypto_shash_setkey(sdesc->shash.tfm, key, drbg_statelen(drbg));
 }
@@ -1723,7 +1723,7 @@ static void drbg_kcapi_hmacsetkey(struct drbg_state *drbg,
 static int drbg_kcapi_hash(struct drbg_state *drbg, unsigned char *outval,
                           const struct list_head *in)
 {
-       struct sdesc *sdesc = (struct sdesc *)drbg->priv_data;
+       struct sdesc *sdesc = drbg->priv_data;
        struct drbg_string *input = NULL;
 
        crypto_shash_init(&sdesc->shash);
@@ -1818,8 +1818,7 @@ static int drbg_init_sym_kernel(struct drbg_state *drbg)
 static void drbg_kcapi_symsetkey(struct drbg_state *drbg,
                                 const unsigned char *key)
 {
-       struct crypto_cipher *tfm =
-               (struct crypto_cipher *)drbg->priv_data;
+       struct crypto_cipher *tfm = drbg->priv_data;
 
        crypto_cipher_setkey(tfm, key, (drbg_keylen(drbg)));
 }
@@ -1827,8 +1826,7 @@ static void drbg_kcapi_symsetkey(struct drbg_state *drbg,
 static int drbg_kcapi_sym(struct drbg_state *drbg, unsigned char *outval,
                          const struct drbg_string *in)
 {
-       struct crypto_cipher *tfm =
-               (struct crypto_cipher *)drbg->priv_data;
+       struct crypto_cipher *tfm = drbg->priv_data;
 
        /* there is only component in *in */
        BUG_ON(in->len < drbg_blocklen(drbg));