[NUI][ATSPI] remove build warning messages
authorShinwoo Kim <cinoo.kim@samsung.com>
Tue, 27 Apr 2021 02:28:42 +0000 (11:28 +0900)
committerdongsug-song <35130733+dongsug-song@users.noreply.github.com>
Fri, 21 May 2021 07:37:43 +0000 (16:37 +0900)
This patch is for removing following build warnings.

(1) Do not nest type SayFinishedEventArgs. Alternatively,
  change its accessibility so that it is not externally visible.

(2) Only FlagsAttribute enums should have plural names

src/Tizen.NUI/src/public/Accessibility/Accessibility.cs
test/NUITestSample/NUITestSample/examples/AtspiTest.cs

index c467ae9..7bccb4c 100755 (executable)
@@ -177,64 +177,6 @@ namespace Tizen.NUI.Accessibility
 
         #region Event, Enum, Struct, ETC
         /// <summary>
-        ///  Say Finished event arguments
-        /// </summary>
-        // This will be public opened after ACR done. (Before ACR, need to be hidden as Inhouse API)
-        [EditorBrowsable(EditorBrowsableState.Never)]
-        public class SayFinishedEventArgs : EventArgs
-        {
-            /// <summary>
-            /// The state of Say finished
-            /// </summary>
-            // This will be public opened after ACR done. (Before ACR, need to be hidden as Inhouse API)
-            [EditorBrowsable(EditorBrowsableState.Never)]
-            public SayFinishedState State
-            {
-                private set;
-                get;
-            }
-
-            internal SayFinishedEventArgs(int result)
-            {
-                State = (SayFinishedState)(result);
-                tlog.Fatal(tag, $"SayFinishedEventArgs Constructor! State={State}");
-            }
-        }
-
-        /// <summary>
-        /// Enum of Say finished event argument status
-        /// </summary>
-        [Obsolete("Please do not use! This will be removed. Please use Accessibility.SayFinishedState instead!")]
-        [EditorBrowsable(EditorBrowsableState.Never)]
-        public enum SayFinishedStates
-        {
-            /// <summary>
-            /// Invalid
-            /// </summary>
-            [Obsolete("Please do not use! This will be removed. Please use Accessibility.SayFinishedState.Invalid instead!")]
-            [EditorBrowsable(EditorBrowsableState.Never)]
-            Invalid = -1,
-            /// <summary>
-            /// Cancelled
-            /// </summary>
-            [Obsolete("Please do not use! This will be removed. Please use Accessibility.SayFinishedState.Invalid instead!")]
-            [EditorBrowsable(EditorBrowsableState.Never)]
-            Cancelled = 1,
-            /// <summary>
-            /// Stopped
-            /// </summary>
-            [Obsolete("Please do not use! This will be removed. Please use Accessibility.SayFinishedState.Invalid instead!")]
-            [EditorBrowsable(EditorBrowsableState.Never)]
-            Stopped = 2,
-            /// <summary>
-            /// Skipped
-            /// </summary>
-            [Obsolete("Please do not use! This will be removed. Please use Accessibility.SayFinishedState.Invalid instead!")]
-            [EditorBrowsable(EditorBrowsableState.Never)]
-            Skipped = 3
-        }
-
-        /// <summary>
         /// Enum of Say finished event argument status
         /// </summary>
         // This will be public opened after ACR done. (Before ACR, need to be hidden as Inhouse API)
@@ -335,4 +277,29 @@ namespace Tizen.NUI.Accessibility
         private static string tag = "NUITEST";
         #endregion Private
     }
+
+    /// <summary>
+    ///  Say Finished event arguments
+    /// </summary>
+    // This will be public opened after ACR done. (Before ACR, need to be hidden as Inhouse API)
+    [EditorBrowsable(EditorBrowsableState.Never)]
+    public class SayFinishedEventArgs : EventArgs
+    {
+        /// <summary>
+        /// The state of Say finished
+        /// </summary>
+        // This will be public opened after ACR done. (Before ACR, need to be hidden as Inhouse API)
+        [EditorBrowsable(EditorBrowsableState.Never)]
+        public Accessibility.SayFinishedState State
+        {
+            private set;
+            get;
+        }
+
+        internal SayFinishedEventArgs(int result)
+        {
+            State = (Accessibility.SayFinishedState)(result);
+            tlog.Fatal("NUITEST", $"SayFinishedEventArgs Constructor! State={State}");
+        }
+    }
 }
index 675ebc2..63eeed0 100755 (executable)
@@ -113,7 +113,7 @@ namespace Tizen.TV.NUI.Example
         private void Instance_SayFinished(object sender, Accessibility.SayFinishedEventArgs e)
         {
             tlog.Fatal(tag, $"Instance_SayFinished()! State={e.State}");
-            if (e.State == Accessibility.SayFinishedStates.Stopped)
+            if (e.State == Accessibility.SayFinishedState.Stopped)
             {
                 Accessibility.Instance.Say("ÀÌ°Ç Äݹé Å×½ºÆ® ÀÔ´Ï´Ù. this is callback test!  ÄݹéÀ» »©·Á¸é È®ÀÎÅ°¸¦ ´©¸£¼¼¿ä. to remove callback please push Return key", true);
             }