Remove inappropriate QSKIP in QTextCodec autotest.
authorJason McDonald <jason.mcdonald@nokia.com>
Wed, 26 Oct 2011 00:52:54 +0000 (10:52 +1000)
committerQt by Nokia <qt-info@nokia.com>
Thu, 27 Oct 2011 01:14:59 +0000 (03:14 +0200)
There were only two ways the QSKIP could be called: (1) the C++ runtime
is broken, or (2) the earlier call to resize the string failed.

In both cases there should be a hard test failure. In the former case, a
broken C++ runtime calls all of the test results into question.  In the
latter case, the QByteArray::resize() method has suffered a regression.

Change-Id: I5adf942d2eb4d746d2ab31e98571c5d9bdd40890
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
tests/auto/corelib/codecs/qtextcodec/tst_qtextcodec.cpp

index c3002a8..4c9fc49 100644 (file)
@@ -340,8 +340,7 @@ void tst_QTextCodec::codecForLocale()
                      originalLocaleEncodedTimeString.size(),
                      "%A%a%B%b%Z",
                      localtime(&t));
-    if (r == 0)
-        QSKIP("strftime() failed");
+    QVERIFY(r != 0);
     originalLocaleEncodedTimeString.resize(r);
 
     QString unicodeTimeString = codec->toUnicode(originalLocaleEncodedTimeString);