drm/msm: fix leaks if initialization fails

We should free resources in unlikely case of allocation failure.

Signed-off-by: Pavel Machek <pavel@denx.de>
Signed-off-by: Rob Clark <robdclark@chromium.org>

diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index e4b750b..7d985f8 100644 (file)
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm/msm_drv.c
@@ -444,8 +444,10 @@ static int msm_drm_init(struct device *dev, struct drm_driver *drv)
        if (!dev->dma_parms) {
                dev->dma_parms = devm_kzalloc(dev, sizeof(*dev->dma_parms),
                                              GFP_KERNEL);
-               if (!dev->dma_parms)
-                       return -ENOMEM;
+               if (!dev->dma_parms) {
+                       ret = -ENOMEM;
+                       goto err_msm_uninit;
+               }
        }
        dma_set_max_seg_size(dev, DMA_BIT_MASK(32));