pwm: crc: Simplify using devm_pwmchip_add()
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Tue, 25 May 2021 20:31:56 +0000 (22:31 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Mon, 28 Jun 2021 11:25:04 +0000 (13:25 +0200)
With devm_pwmchip_add() we can drop pwmchip_remove() from the device
remove callback. The latter can then go away, too and as this is the
only user of platform_get_drvdata(), the respective call to
platform_set_drvdata() can go, too.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-crc.c

index 02522a9..7b357d1 100644 (file)
@@ -173,21 +173,11 @@ static int crystalcove_pwm_probe(struct platform_device *pdev)
        /* get the PMIC regmap */
        pwm->regmap = pmic->regmap;
 
-       platform_set_drvdata(pdev, pwm);
-
-       return pwmchip_add(&pwm->chip);
-}
-
-static int crystalcove_pwm_remove(struct platform_device *pdev)
-{
-       struct crystalcove_pwm *pwm = platform_get_drvdata(pdev);
-
-       return pwmchip_remove(&pwm->chip);
+       return devm_pwmchip_add(&pdev->dev, &pwm->chip);
 }
 
 static struct platform_driver crystalcove_pwm_driver = {
        .probe = crystalcove_pwm_probe,
-       .remove = crystalcove_pwm_remove,
        .driver = {
                .name = "crystal_cove_pwm",
        },