platform/x86: apple-gmux: don't use be32_to_cpu and cpu_to_be32
authorOrlando Chamberlain <orlandoch.dev@gmail.com>
Wed, 14 Jun 2023 06:49:32 +0000 (16:49 +1000)
committerHans de Goede <hdegoede@redhat.com>
Fri, 16 Jun 2023 14:47:44 +0000 (16:47 +0200)
Sparce doesn't seem to like using be32_to_cpu and cpu_to_be32 to convert
values for the MMIO gmux to/from the host architecture.

Instead use iowrite32be and ioread32be to always convert, which should be
fine because apple-gmux is only used on x86 with is always little endian.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202305161712.5l3f4iI4-lkp@intel.com/
Signed-off-by: Orlando Chamberlain <orlandoch.dev@gmail.com>
Link: https://lore.kernel.org/r/20230614064931.3263-2-orlandoch.dev@gmail.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/apple-gmux.c

index e02b4ae..cadbb55 100644 (file)
@@ -278,7 +278,7 @@ static u32 gmux_mmio_read32(struct apple_gmux_data *gmux_data, int port)
        iowrite8(GMUX_MMIO_READ | sizeof(val),
                gmux_data->iomem_base + GMUX_MMIO_COMMAND_SEND);
        gmux_mmio_wait(gmux_data);
-       val = be32_to_cpu(ioread32(gmux_data->iomem_base));
+       val = ioread32be(gmux_data->iomem_base);
        mutex_unlock(&gmux_data->index_lock);
 
        return val;
@@ -288,7 +288,7 @@ static void gmux_mmio_write32(struct apple_gmux_data *gmux_data, int port,
                               u32 val)
 {
        mutex_lock(&gmux_data->index_lock);
-       iowrite32(cpu_to_be32(val), gmux_data->iomem_base);
+       iowrite32be(val, gmux_data->iomem_base);
        iowrite8(port & 0xff, gmux_data->iomem_base + GMUX_MMIO_PORT_SELECT);
        iowrite8(GMUX_MMIO_WRITE | sizeof(val),
                gmux_data->iomem_base + GMUX_MMIO_COMMAND_SEND);