elm_genlist: do not check scroll if show_item is NULL
authorMinkyu Kang <mk7.kang@samsung.com>
Tue, 7 Feb 2017 23:00:35 +0000 (15:00 -0800)
committerCedric BAIL <cedric@osg.samsung.com>
Tue, 7 Feb 2017 23:14:54 +0000 (15:14 -0800)
Summary:
If show_item is NULL then does not need to check scroll.
But, sometimes show_item is NULL but check_scroll is true.
It was wrong and can makes a crash.

Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
Reviewers: cedric, Hermet, SanghyeonLee, raster

Subscribers: jpeg

Differential Revision: https://phab.enlightenment.org/D4569

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
src/lib/elementary/elm_genlist.c

index d880809..fe79a12 100644 (file)
@@ -833,6 +833,7 @@ _calc_job(void *data)
         if (!sd->must_recalc_idler)
           sd->must_recalc_idler = ecore_idler_add(_must_recalc_idler, data);
      }
+   if (!sd->show_item) sd->check_scroll = EINA_FALSE;
    if (sd->check_scroll)
      {
         elm_obj_pan_content_size_get(sd->pan_obj, &pan_w, &pan_h);