pixman-renderer: fail to zoom more gracefully
authorDerek Foreman <derekf@osg.samsung.com>
Mon, 1 Sep 2014 15:33:28 +0000 (10:33 -0500)
committerPekka Paalanen <pekka.paalanen@collabora.co.uk>
Wed, 3 Sep 2014 13:18:47 +0000 (16:18 +0300)
When zoom is activated in the pixman rendered the log is filled with warnings
and all rendering stops.  With this patch the warning is generated once and
rendering continues without zooming.

Closes bug 80258

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=80258
Tested-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
src/pixman-renderer.c

index 4fdcb05..351f00e 100644 (file)
@@ -385,6 +385,7 @@ static void
 draw_view(struct weston_view *ev, struct weston_output *output,
          pixman_region32_t *damage) /* in global coordinates */
 {
+       static int zoom_logged = 0;
        struct pixman_surface_state *ps = get_surface_state(ev->surface);
        /* repaint bounding region in global coordinates: */
        pixman_region32_t repaint;
@@ -403,9 +404,9 @@ draw_view(struct weston_view *ev, struct weston_output *output,
        if (!pixman_region32_not_empty(&repaint))
                goto out;
 
-       if (output->zoom.active) {
+       if (output->zoom.active && !zoom_logged) {
                weston_log("pixman renderer does not support zoom\n");
-               goto out;
+               zoom_logged = 1;
        }
 
        /* TODO: Implement repaint_region_complex() using pixman_composite_trapezoids() */