videobalance: avoid deadlock
authorWim Taymans <wim.taymans@collabora.co.uk>
Tue, 4 Sep 2012 10:35:53 +0000 (12:35 +0200)
committerWim Taymans <wim.taymans@collabora.co.uk>
Tue, 4 Sep 2012 10:35:53 +0000 (12:35 +0200)
_update_properties takes the object lock and should not be called when the
object lock is already taken.

gst/videofilter/gstvideobalance.c

index 4653b24..9e0c9af 100644 (file)
@@ -601,10 +601,10 @@ gst_video_balance_colorbalance_set_value (GstColorBalance * balance,
     changed = new_val != vb->contrast;
     vb->contrast = new_val;
   }
+  GST_OBJECT_UNLOCK (vb);
 
   if (changed)
     gst_video_balance_update_properties (vb);
-  GST_OBJECT_UNLOCK (vb);
 
   if (changed) {
     gst_color_balance_value_changed (balance, channel,