drm/mipi-dsi: Detach devices when removing the host
authorMaxime Ripard <maxime@cerno.tech>
Mon, 11 Jul 2022 17:38:31 +0000 (19:38 +0200)
committerMaxime Ripard <maxime@cerno.tech>
Wed, 13 Jul 2022 08:46:05 +0000 (10:46 +0200)
Whenever the MIPI-DSI host is unregistered, the code of
mipi_dsi_host_unregister() loops over every device currently found on that
bus and will unregister it.

However, it doesn't detach it from the bus first, which leads to all kind
of resource leaks if the host wants to perform some clean up whenever a
device is detached.

Fixes: 068a00233969 ("drm: Add MIPI DSI bus support")
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://lore.kernel.org/r/20220711173939.1132294-2-maxime@cerno.tech
drivers/gpu/drm/drm_mipi_dsi.c

index 2e25804d6ffa141222fc923f178e6cc13f839716..3ec02748d56fe032bab48947cd1097098b974204 100644 (file)
@@ -346,6 +346,7 @@ static int mipi_dsi_remove_device_fn(struct device *dev, void *priv)
 {
        struct mipi_dsi_device *dsi = to_mipi_dsi_device(dev);
 
+       mipi_dsi_detach(dsi);
        mipi_dsi_device_unregister(dsi);
 
        return 0;