Fix uninitialized member 49/30649/2
authorZofia Abramowska <z.abramowska@samsung.com>
Fri, 21 Nov 2014 14:43:28 +0000 (15:43 +0100)
committerLukasz Wojciechowski <l.wojciechow@partner.samsung.com>
Mon, 24 Nov 2014 11:02:04 +0000 (03:02 -0800)
Descriptor could return uninitialized BinaryQueuePtr.

Change-Id: I53fbc739438e8316ca5c4b81eec5139b6732aea2

src/service/sockets/Descriptor.cpp
src/service/sockets/Descriptor.h

index b2e9459..e247f7f 100644 (file)
@@ -34,6 +34,11 @@ void Descriptor::checkQueues(void) {
         m_readQueue = std::make_shared<BinaryQueue>();
 }
 
+BinaryQueuePtr Descriptor::writeQueue(void) {
+    checkQueues();
+    return m_writeQueue;
+}
+
 bool Descriptor::hasDataToWrite(void) const {
     if (m_writeQueue)
         return !(m_writeQueue->empty() && m_writeBuffer.empty());
index 5d77028..a9a6c68 100644 (file)
@@ -57,9 +57,7 @@ public:
 
     ResponseTakerPtr responseTaker(void) const;
 
-    BinaryQueuePtr writeQueue(void) {
-        return m_writeQueue;
-    }
+    BinaryQueuePtr writeQueue(void);
 
     void setProtocol(ProtocolPtr protocol) {
         m_protocol = protocol;