net: bcmdhd: fix not to check same value in macro
authorSeung-Woo Kim <sw0312.kim@samsung.com>
Tue, 17 Jan 2017 04:22:22 +0000 (13:22 +0900)
committerJaehoon Chung <jh80.chung@samsung.com>
Tue, 29 Jan 2019 02:25:31 +0000 (11:25 +0900)
When BCMBUSTYPE is not defined, then BUSTYPE(bustype) is just
bustype. So comparing bustype and BUSTYPE(bustype) is not necessary.
Fix not to check the same values.

This patch removes following build warning with gcc 6.
   drivers/net/wireless/bcmdhd/siutils.c: In function 'si_doattach':
   drivers/net/wireless/bcmdhd/siutils.c:564:14: warning: self-comparison always evaluates to false [-Wtautological-compare]
     if (bustype != BUSTYPE(bustype)) {
                 ^~

Change-Id: I1cac3dd31bcb86983469830013a1093ed9ceaa89
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
drivers/net/wireless/bcmdhd/siutils.c

index 4a5f3fef1afe3046f5ff6466ab9dffa4ceda6473..9406180f5cf47c5b6164e5baa834da77c29d1105 100644 (file)
@@ -561,11 +561,13 @@ si_doattach(si_info_t *sii, uint devid, osl_t *osh, void *regs,
        }
 
        sih->bustype = bustype;
+#ifdef BCMBUSTYPE
        if (bustype != BUSTYPE(bustype)) {
                SI_ERROR(("si_doattach: bus type %d does not match configured bus type %d\n",
                        bustype, BUSTYPE(bustype)));
                return NULL;
        }
+#endif
 
        /* bus/core/clk setup for register access */
        if (!si_buscore_prep(sii, bustype, devid, sdh)) {