staging: r8188eu: remove NULL check for usb_kill_urb
authorMartin Kaiser <martin@kaiser.cx>
Wed, 11 Jan 2023 10:02:01 +0000 (11:02 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 17 Jan 2023 18:36:17 +0000 (19:36 +0100)
usb_kill_urb handles a NULL parameter. There's no need for NULL checks
before we call usb_kill_urb.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Link: https://lore.kernel.org/r/20230111100201.251905-1-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/os_dep/usb_ops_linux.c

index 62106d2..5835336 100644 (file)
@@ -29,8 +29,7 @@ void rtw_read_port_cancel(struct adapter *padapter)
 
        for (i = 0; i < NR_RECVBUFF; i++) {
                precvbuf->reuse = true;
-               if (precvbuf->purb)
-                       usb_kill_urb(precvbuf->purb);
+               usb_kill_urb(precvbuf->purb);
                precvbuf++;
        }
 }
@@ -153,15 +152,13 @@ void rtw_write_port_cancel(struct adapter *padapter)
        padapter->bWritePortCancel = true;
 
        for (i = 0; i < NR_XMITBUFF; i++) {
-               if (pxmitbuf->pxmit_urb)
-                       usb_kill_urb(pxmitbuf->pxmit_urb);
+               usb_kill_urb(pxmitbuf->pxmit_urb);
                pxmitbuf++;
        }
 
        pxmitbuf = (struct xmit_buf *)padapter->xmitpriv.pxmit_extbuf;
        for (i = 0; i < NR_XMIT_EXTBUFF; i++) {
-               if (pxmitbuf->pxmit_urb)
-                       usb_kill_urb(pxmitbuf->pxmit_urb);
+               usb_kill_urb(pxmitbuf->pxmit_urb);
                pxmitbuf++;
        }
 }