Allow line break at the end of string. UAX#14 rule LB3 says "Always break

2008-04-24  Behdad Esfahbod  <behdad@gnome.org>

        * pango/break.c (pango_default_break): Allow line break at the end of
        string.  UAX#14 rule LB3 says "Always break at the end of text."
        With this test, Pango passes the LineBreakTest.txt, sans the bug in
        the test file that I've already reported to unicoRe.

svn path=/trunk/; revision=2613

diff --git a/ChangeLog b/ChangeLog
index 370bc8d..3c25ad7 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2008-04-24  Behdad Esfahbod  <behdad@gnome.org>
+
+       * pango/break.c (pango_default_break): Allow line break at the end of
+       string.  UAX#14 rule LB3 says "Always break at the end of text."
+       With this test, Pango passes the LineBreakTest.txt, sans the bug in
+       the test file that I've already reported to unicoRe.
+
 2008-04-21  Behdad Esfahbod  <behdad@gnome.org>
 
        * === Released 1.21.0 ===

diff --git a/pango/break.c b/pango/break.c
index fba8b85..5a1e917 100644 (file)
--- a/pango/break.c
+++ b/pango/break.c
@@ -743,7 +743,7 @@ pango_default_break (const gchar   *text,
 
       g_assert (prev_break_type != G_UNICODE_BREAK_SPACE);
 
-      attrs[i].is_line_break = FALSE;
+      attrs[i].is_line_break = done; /* XXX ugly */
       attrs[i].is_mandatory_break = FALSE;
 
       if (attrs[i].is_cursor_position) /* If it's not a grapheme boundary,