Fix a few async void tests to be async Task (#82914)
authorStephen Toub <stoub@microsoft.com>
Fri, 3 Mar 2023 04:15:36 +0000 (23:15 -0500)
committerGitHub <noreply@github.com>
Fri, 3 Mar 2023 04:15:36 +0000 (23:15 -0500)
src/libraries/System.Formats.Tar/tests/TarWriter/TarWriter.Async.Tests.cs
src/libraries/System.Net.Security/tests/FunctionalTests/NegotiateAuthenticationKerberosTest.cs
src/libraries/System.Runtime.Caching/tests/System.Runtime.Caching/CountersTest.cs
src/libraries/System.Runtime/tests/System/Threading/PeriodicTimerTests.cs
src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/Regex.Match.Tests.cs
src/libraries/System.Threading.RateLimiting/tests/TokenBucketRateLimiterTests.cs
src/libraries/System.Threading.Tasks/tests/CancellationTokenTests.cs
src/libraries/System.Threading.Tasks/tests/TaskToAsyncResultTests.cs

index f52bf31..d9188e0 100644 (file)
@@ -37,7 +37,7 @@ namespace System.Formats.Tar.Tests
         }
 
         [Fact]
-        public async void Write_To_UnseekableStream_Async()
+        public async Task Write_To_UnseekableStream_Async()
         {
             await using (MemoryStream inner = new MemoryStream())
             {
index 3bb9a1a..d7149f8 100644 (file)
@@ -62,7 +62,7 @@ namespace System.Net.Security.Tests
         }
 
         [Fact]
-        public async void Invalid_Token()
+        public async Task Invalid_Token()
         {
             using var kerberosExecutor = new KerberosExecutor(_testOutputHelper, "LINUX.CONTOSO.COM");
             // Force a non-empty keytab to make macOS happy
index e7de74d..3fea8fb 100644 (file)
@@ -28,7 +28,7 @@ namespace MonoTests.System.Runtime.Caching
     {
         [Fact]
         [SkipOnPlatform(TestPlatforms.Browser, "Wasm is single-threaded, which makes TestEventListener ineffective.")]
-        public async void Basic_Counters()
+        public async Task Basic_Counters()
         {
             string cacheName = "Basic_Counters_Test";
             var cip = new CacheItemPolicy() { /* _absExpiry = ObjectCache.InfiniteAbsoluteExpiration */ };
index f96b0b1..82d6b0a 100644 (file)
@@ -51,7 +51,7 @@ namespace System.Threading.Tests
         }
 
         [Fact]
-        public async void Period_AffectsPendingWaits()
+        public async Task Period_AffectsPendingWaits()
         {
             using PeriodicTimer timer = new PeriodicTimer(TimeSpan.FromDays(40));
 
index cb92846..6311cdf 100644 (file)
@@ -1151,7 +1151,7 @@ namespace System.Text.RegularExpressions.Tests
 
         [Theory]
         [MemberData(nameof(Match_DeepNesting_MemberData))]
-        public async void Match_DeepNesting(RegexEngine engine, int count)
+        public async Task Match_DeepNesting(RegexEngine engine, int count)
         {
             const string Start = @"((?>abc|(?:def[ghi]", End = @")))";
             const string Match = "defg";
index a96bb63..4438848 100644 (file)
@@ -966,7 +966,7 @@ namespace System.Threading.RateLimiting.Test
         }
 
         [Fact]
-        public async void TryReplenishWithAllTokensAvailable_Noops()
+        public async Task TryReplenishWithAllTokensAvailable_Noops()
         {
             var limiter = new TokenBucketRateLimiter(new TokenBucketRateLimiterOptions
             {
index 4d2c89b..cd01a0e 100644 (file)
@@ -1749,7 +1749,7 @@ namespace System.Threading.Tasks.Tests
         }
 
         [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
-        public static async void CancellationTokenSource_CancelAsync_CallbacksInvokedAsynchronously()
+        public static async Task CancellationTokenSource_CancelAsync_CallbacksInvokedAsynchronously()
         {
             var cts = new CancellationTokenSource();
 
index 57d703f..d0ee2a6 100644 (file)
@@ -83,7 +83,7 @@ namespace System.Threading.Tasks.Tests
         }
 
         [Fact]
-        public async void BeginFromTask_CompletedAsynchronously_CallbackInvokedAsynchronously()
+        public async Task BeginFromTask_CompletedAsynchronously_CallbackInvokedAsynchronously()
         {
             var tcs = new TaskCompletionSource();
             var invoked = new TaskCompletionSource();