drm/udl: Remove error check from fbdev setup
authorThomas Zimmermann <tzimmermann@suse.de>
Wed, 8 Apr 2020 08:26:39 +0000 (10:26 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Wed, 8 Apr 2020 14:24:59 +0000 (16:24 +0200)
Remove the error check from the fbdev setup function. The driver's
probe function should not depend on a DRM client's state.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Noralf Trønnes <noralf@tronnes.org>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200408082641.590-9-tzimmermann@suse.de
drivers/gpu/drm/udl/udl_drv.c

index 1ce2d865c36dccfa032cb43252ddfd8751788c6c..9cc6d075cb402cf2b24d4138c8f23d2adc6fd401 100644 (file)
@@ -97,14 +97,10 @@ static int udl_usb_probe(struct usb_interface *interface,
 
        DRM_INFO("Initialized udl on minor %d\n", udl->drm.primary->index);
 
-       r = drm_fbdev_generic_setup(&udl->drm, 0);
-       if (r)
-               goto err_drm_dev_unregister;
+       drm_fbdev_generic_setup(&udl->drm, 0);
 
        return 0;
 
-err_drm_dev_unregister:
-       drm_dev_unregister(&udl->drm);
 err_free:
        drm_dev_put(&udl->drm);
        return r;