memory leak fix - missed to free web data from browser_provider 09/49309/2 accepted/tizen/tv/20151013.040524 submit/tizen/20151013.004713
authorSoohye Shin <soohye.shin@samsung.com>
Mon, 12 Oct 2015 11:49:10 +0000 (20:49 +0900)
committerSoohye Shin <soohye.shin@samsung.com>
Mon, 12 Oct 2015 11:51:07 +0000 (20:51 +0900)
Change-Id: I10fac4324eace6c7698b1edbd1c40e9843bcdeda
Signed-off-by: Soohye Shin <soohye.shin@samsung.com>
src/data/data_recent.c

index d995025..4c2433c 100644 (file)
@@ -434,31 +434,31 @@ static void _web_list_foreach(gpointer data, gpointer user_data)
        r = bp_history_adaptor_get_title(id, &title);
        if (r < 0) {
                _ERR("failed to get title of history");
-               goto err;
+               goto err1;
        }
 
        r = bp_history_adaptor_get_url(id, &url);
        if (r < 0) {
                _ERR("failed to get url of history");
-               goto err;
+               goto err2;
        }
 
        r = bp_history_adaptor_get_date_visited(id, &time);
        if (r < 0) {
                _ERR("failed to get icon of history");
-               goto err;
+               goto err3;
        }
 
        r = bp_history_adaptor_get_snapshot(id, &w, &h, &value, &size);
        if (r < 0) {
                _ERR("failed to get snapshot of history");
-               goto err;
+               goto err3;
        }
 
        di = _new_datamgr_item(title, url, APP_ID_BROWSER, NULL, NULL, url,
                        IMAGE_RECENT_ICON_WEB, 1, time);
        if (!di)
-               goto err;
+               goto err3;
 
        thumbnail = calloc(1, sizeof(*thumbnail));
        if (thumbnail) {
@@ -474,7 +474,11 @@ static void _web_list_foreach(gpointer data, gpointer user_data)
        }
        dm->list = eina_list_append(dm->list, di);
 
-err:
+err3:
+       free(url);
+err2:
+       free(title);
+err1:
        bp_history_adaptor_deinitialize();
 }