arm: qemu: Move GUIDs to the C file

These are only used in one place, so move them there.

Signed-off-by: Simon Glass <sjg@chromium.org>

diff --git a/board/emulation/qemu-arm/qemu-arm.c b/board/emulation/qemu-arm/qemu-arm.c
index 3df3e41c0b2cacd3fd9692d1f080767c50d5097d..dae37640bc5bb2e43341117335ca787e3676631b 100644 (file)
--- a/board/emulation/qemu-arm/qemu-arm.c
+++ b/board/emulation/qemu-arm/qemu-arm.c
@@ -15,6 +15,16 @@
 #include <virtio.h>
 
 #include <linux/kernel.h>
+#include <linux/sizes.h>
+
+/* GUIDs for capsule updatable firmware images */
+#define QEMU_ARM_UBOOT_IMAGE_GUID \
+       EFI_GUID(0xf885b085, 0x99f8, 0x45af, 0x84, 0x7d, \
+                0xd5, 0x14, 0x10, 0x7a, 0x4a, 0x2c)
+
+#define QEMU_ARM64_UBOOT_IMAGE_GUID \
+       EFI_GUID(0x058b7d83, 0x50d5, 0x4c47, 0xa1, 0x95, \
+                0x60, 0xd8, 0x6a, 0xd3, 0x41, 0xc4)
 
 #ifdef CONFIG_ARM64
 #include <asm/armv8/mmu.h>

diff --git a/configs/qemu_arm64_defconfig b/configs/qemu_arm64_defconfig
index 40aec927fc91dfa34d0b482fc6cf445f074048a4..f66ad32fc9b91f3c153db57c7d69236c701c5bec 100644 (file)
--- a/configs/qemu_arm64_defconfig
+++ b/configs/qemu_arm64_defconfig
@@ -72,3 +72,4 @@ CONFIG_USB=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_PCI=y
 CONFIG_TPM=y
+CONFIG_HUSH_PARSER=y

diff --git a/configs/qemu_arm_defconfig b/configs/qemu_arm_defconfig
index ad02526a5dcb3be5767f9173779d2f2c51e4297d..c2e25c1d6bcb25100bcece3059cc43e638d20458 100644 (file)
--- a/configs/qemu_arm_defconfig
+++ b/configs/qemu_arm_defconfig
@@ -74,3 +74,4 @@ CONFIG_USB=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_PCI=y
 CONFIG_TPM=y
+CONFIG_HUSH_PARSER=y

diff --git a/include/configs/qemu-arm.h b/include/configs/qemu-arm.h
index 77ab573825437133f4ec979522bc68730f780ffb..e296f3987983e47c16428a53102cf22bf919afe6 100644 (file)
--- a/include/configs/qemu-arm.h
+++ b/include/configs/qemu-arm.h
@@ -6,21 +6,9 @@
 #ifndef __CONFIG_H
 #define __CONFIG_H
 
-#include <linux/sizes.h>
-
 /* Physical memory map */
-
 #define CFG_SYS_SDRAM_BASE             0x40000000
 
-/* GUIDs for capsule updatable firmware images */
-#define QEMU_ARM_UBOOT_IMAGE_GUID \
-       EFI_GUID(0xf885b085, 0x99f8, 0x45af, 0x84, 0x7d, \
-                0xd5, 0x14, 0x10, 0x7a, 0x4a, 0x2c)
-
-#define QEMU_ARM64_UBOOT_IMAGE_GUID \
-       EFI_GUID(0x058b7d83, 0x50d5, 0x4c47, 0xa1, 0x95, \
-                0x60, 0xd8, 0x6a, 0xd3, 0x41, 0xc4)
-
 /* For timer, QEMU emulates an ARMv7/ARMv8 architected timer */
 
 #endif /* __CONFIG_H */

diff --git a/test/boot/bootdev.c b/test/boot/bootdev.c
index de8dd66b824db7f8a935e2770a129b7c0c795920..e1eb8ccd9a7d113b6752ceea475c3e71e6e2e797 100644 (file)
--- a/test/boot/bootdev.c
+++ b/test/boot/bootdev.c
@@ -320,11 +320,12 @@ static int bootdev_test_hunter(struct unit_test_state *uts)
        ut_assert_nextline("   5        ide              ide_bootdev");
        ut_assert_nextline("   2        mmc              mmc_bootdev");
        ut_assert_nextline("   4        nvme             nvme_bootdev");
+       ut_assert_nextline("   4        qfw              qfw_bootdev");
        ut_assert_nextline("   4        scsi             scsi_bootdev");
        ut_assert_nextline("   4        spi_flash        sf_bootdev");
        ut_assert_nextline("   5        usb              usb_bootdev");
        ut_assert_nextline("   4        virtio           virtio_bootdev");
-       ut_assert_nextline("(total hunters: 9)");
+       ut_assert_nextline("(total hunters: 10)");
        ut_assert_console_end();
 
        ut_assertok(bootdev_hunt("usb1", false));
@@ -332,8 +333,8 @@ static int bootdev_test_hunter(struct unit_test_state *uts)
                "Bus usb@1: scanning bus usb@1 for devices... 5 USB Device(s) found");
        ut_assert_console_end();
 
-       /* USB is sixth in the list, so bit 7 */
-       ut_asserteq(BIT(7), std->hunters_used);
+       /* USB is 7th in the list, so bit 8 */
+       ut_asserteq(BIT(8), std->hunters_used);
 
        return 0;
 }
@@ -354,7 +355,7 @@ static int bootdev_test_cmd_hunt(struct unit_test_state *uts)
        ut_assert_nextline("Prio  Used  Uclass           Hunter");
        ut_assert_nextlinen("----");
        ut_assert_nextline("   6        ethernet         eth_bootdev");
-       ut_assert_skip_to_line("(total hunters: 9)");
+       ut_assert_skip_to_line("(total hunters: 10)");
        ut_assert_console_end();
 
        /* Use the MMC hunter and see that it updates */
@@ -362,7 +363,7 @@ static int bootdev_test_cmd_hunt(struct unit_test_state *uts)
        ut_assertok(run_command("bootdev hunt -l", 0));
        ut_assert_skip_to_line("   5        ide              ide_bootdev");
        ut_assert_nextline("   2     *  mmc              mmc_bootdev");
-       ut_assert_skip_to_line("(total hunters: 9)");
+       ut_assert_skip_to_line("(total hunters: 10)");
        ut_assert_console_end();
 
        /* Scan all hunters */
@@ -380,6 +381,7 @@ static int bootdev_test_cmd_hunt(struct unit_test_state *uts)
        /* mmc hunter has already been used so should not run again */
 
        ut_assert_nextline("Hunting with: nvme");
+       ut_assert_nextline("Hunting with: qfw");
        ut_assert_nextline("Hunting with: scsi");
        ut_assert_nextline("scanning bus for devices...");
        ut_assert_skip_to_line("Hunting with: spi_flash");
@@ -398,11 +400,12 @@ static int bootdev_test_cmd_hunt(struct unit_test_state *uts)
        ut_assert_nextline("   5     *  ide              ide_bootdev");
        ut_assert_nextline("   2     *  mmc              mmc_bootdev");
        ut_assert_nextline("   4     *  nvme             nvme_bootdev");
+       ut_assert_nextline("   4     *  qfw              qfw_bootdev");
        ut_assert_nextline("   4     *  scsi             scsi_bootdev");
        ut_assert_nextline("   4     *  spi_flash        sf_bootdev");
        ut_assert_nextline("   5     *  usb              usb_bootdev");
        ut_assert_nextline("   4     *  virtio           virtio_bootdev");
-       ut_assert_nextline("(total hunters: 9)");
+       ut_assert_nextline("(total hunters: 10)");
        ut_assert_console_end();
 
        ut_asserteq(GENMASK(MAX_HUNTER, 0), std->hunters_used);
@@ -589,8 +592,8 @@ static int bootdev_test_next_label(struct unit_test_state *uts)
        ut_asserteq_str("scsi.id0lun0.bootdev", dev->name);
        ut_asserteq(BOOTFLOW_METHF_SINGLE_UCLASS, mflags);
 
-       /* SCSI is sixth in the list, so bit 5 */
-       ut_asserteq(BIT(MMC_HUNTER) | BIT(5), std->hunters_used);
+       /* SCSI is 7th in the list, so bit 6 */
+       ut_asserteq(BIT(MMC_HUNTER) | BIT(6), std->hunters_used);
 
        ut_assertok(bootdev_next_label(&iter, &dev, &mflags));
        ut_assert_console_end();
@@ -600,7 +603,7 @@ static int bootdev_test_next_label(struct unit_test_state *uts)
                    mflags);
 
        /* dhcp: Ethernet is first so bit 0 */
-       ut_asserteq(BIT(MMC_HUNTER) | BIT(5) | BIT(0), std->hunters_used);
+       ut_asserteq(BIT(MMC_HUNTER) | BIT(6) | BIT(0), std->hunters_used);
 
        ut_assertok(bootdev_next_label(&iter, &dev, &mflags));
        ut_assert_console_end();
@@ -610,7 +613,7 @@ static int bootdev_test_next_label(struct unit_test_state *uts)
                    mflags);
 
        /* pxe: Ethernet is first so bit 0 */
-       ut_asserteq(BIT(MMC_HUNTER) | BIT(5) | BIT(0), std->hunters_used);
+       ut_asserteq(BIT(MMC_HUNTER) | BIT(6) | BIT(0), std->hunters_used);
 
        mflags = 123;
        ut_asserteq(-ENODEV, bootdev_next_label(&iter, &dev, &mflags));
@@ -618,7 +621,7 @@ static int bootdev_test_next_label(struct unit_test_state *uts)
        ut_assert_console_end();
 
        /* no change */
-       ut_asserteq(BIT(MMC_HUNTER) | BIT(5) | BIT(0), std->hunters_used);
+       ut_asserteq(BIT(MMC_HUNTER) | BIT(6) | BIT(0), std->hunters_used);
 
        return 0;
 }

diff --git a/test/boot/bootstd_common.h b/test/boot/bootstd_common.h
index 136a79b51784b9f0e9710c97586b9f1af326c542..4a126e43ff44e412465423a58ce687628d5409fd 100644 (file)
--- a/test/boot/bootstd_common.h
+++ b/test/boot/bootstd_common.h
@@ -21,7 +21,7 @@
 #define TEST_VERNUM            0x00010002
 
 enum {
-       MAX_HUNTER      = 8,
+       MAX_HUNTER      = 9,
        MMC_HUNTER      = 3,    /* ID of MMC hunter */
 };