Fix static analysis issue

The following issue is fixed:
 - ODR_VIOLATION

Change-Id: Icece742e174148c3af52fed4e7346a04b51e1790
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>

diff --git a/src/exception-internal.cc b/src/exception-internal.cc
index 8e21f20..2af6bfb 100644 (file)
--- a/src/exception-internal.cc
+++ b/src/exception-internal.cc
@@ -26,8 +26,6 @@ Exception::Exception(int error_code, const std::string& file, int line)
       message_(std::move(GetErrorMessage(error_code_, file, line))) {
 }
 
-Exception::~Exception() = default;
-
 const char* Exception::what() const noexcept {
   return message_.c_str();
 }

diff --git a/src/exception-internal.hh b/src/exception-internal.hh
index 4f52240..655fbae 100644 (file)
--- a/src/exception-internal.hh
+++ b/src/exception-internal.hh
@@ -28,7 +28,7 @@ namespace internal {
 class Exception : public std::exception {
  public:
   explicit Exception(int error_code, const std::string& file, int line);
-  virtual ~Exception();
+  virtual ~Exception() = default;
 
   virtual const char* what() const noexcept;
   int GetErrorCode();

diff --git a/src/request-internal.cc b/src/request-internal.cc
index af78026..c293c29 100644 (file)
--- a/src/request-internal.cc
+++ b/src/request-internal.cc
@@ -26,10 +26,6 @@ Request::Request(std::string instance, std::string port_type)
       port_type_(std::move(port_type)) {
 }
 
-Request::Request() = default;
-
-Request::~Request() = default;
-
 void Request::SetPortType(std::string port_type) {
   port_type_ = std::move(port_type);
 }

diff --git a/src/request-internal.hh b/src/request-internal.hh
index bd72505..3aa9b05 100644 (file)
--- a/src/request-internal.hh
+++ b/src/request-internal.hh
@@ -28,8 +28,8 @@ namespace internal {
 class Request : public tizen_base::Parcelable {
  public:
   Request(std::string instance, std::string port_type);
-  Request();
-  ~Request();
+  Request() = default;
+  ~Request() = default;
 
   void SetPortType(std::string port_type);
   const std::string& GetInstance();

diff --git a/src/response-internal.cc b/src/response-internal.cc
index 3583dde..9d32604 100644 (file)
--- a/src/response-internal.cc
+++ b/src/response-internal.cc
@@ -25,8 +25,6 @@ Response::Response(int result) : result_(result) {
 Response::Response() : result_(0) {
 }
 
-Response::~Response() = default;
-
 int Response::GetResult() {
   return result_;
 }

diff --git a/src/response-internal.hh b/src/response-internal.hh
index 25227d3..2c12ab2 100644 (file)
--- a/src/response-internal.hh
+++ b/src/response-internal.hh
@@ -27,7 +27,7 @@ class Response : public tizen_base::Parcelable {
  public:
   explicit Response(int result);
   Response();
-  ~Response();
+  ~Response() = default;
 
   int GetResult();
 

diff --git a/utils/message.cc b/utils/message.cc
index 47be341..c4145bc 100644 (file)
--- a/utils/message.cc
+++ b/utils/message.cc
@@ -41,8 +41,6 @@ Message::Message(time_t time, int pid, std::string port_name,
     data_(std::move(data)) {
 }
 
-Message::~Message() = default;
-
 void Message::Print() {
   struct tm sent_time;
   localtime_r(&time_, &sent_time);

diff --git a/utils/message.hh b/utils/message.hh
index 9157b2b..098a4f5 100644 (file)
--- a/utils/message.hh
+++ b/utils/message.hh
@@ -30,7 +30,7 @@ class Message {
   Message(time_t time, int pid, std::string port_name, std::string destination,
       bool is_delegate, int port, bool is_read, uint32_t seq,
       std::vector<unsigned char> data);
-  virtual ~Message();
+  virtual ~Message() = default;
 
   void Print();