btrfs-progs: fix qgroup realloc inheritance
authorZach Brown <zab@redhat.com>
Wed, 14 Aug 2013 23:16:40 +0000 (16:16 -0700)
committerDavid Sterba <dsterba@suse.cz>
Tue, 3 Sep 2013 17:41:07 +0000 (19:41 +0200)
qgroup.c:82:23: warning: memcpy with byte count of 0
qgroup.c:83:23: warning: memcpy with byte count of 0

The inheritance wasn't copying qgroups[] because a confused sizeof()
gave 0 byte memcpy()s.  It's been like this for the year since it was
merged, so I guess this isn't a very important thing to do :).

Signed-off-by: Zach Brown <zab@redhat.com>
Reviewed-by: Arne Jansen <sensille@gmx.net>
Signed-off-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Chris Mason <chris.mason@fusionio.com>
qgroup.c

index 038c4dc..86fe2b2 100644 (file)
--- a/qgroup.c
+++ b/qgroup.c
@@ -74,7 +74,7 @@ qgroup_inherit_realloc(struct btrfs_qgroup_inherit **inherit, int n, int pos)
 
        if (*inherit) {
                struct btrfs_qgroup_inherit *i = *inherit;
-               int s = sizeof(out->qgroups);
+               int s = sizeof(out->qgroups[0]);
 
                out->num_qgroups = i->num_qgroups;
                out->num_ref_copies = i->num_ref_copies;