projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
4fb3593
)
ASoC: audio-graph-card: Add of_node_put() in fail path
author
Liang He
<windhl@126.com>
Thu, 21 Jul 2022 14:43:08 +0000
(22:43 +0800)
committer
Mark Brown
<broonie@kernel.org>
Thu, 21 Jul 2022 22:25:54 +0000
(23:25 +0100)
In asoc_simple_parse_dai(), we should call of_node_put() for the
reference returned by of_graph_get_port_parent() in fail path.
Fixes:
ae30a694da4c
("ASoC: simple-card-utils: add asoc_simple_card_parse_dai()")
Signed-off-by: Liang He <windhl@126.com>
Link:
https://lore.kernel.org/r/20220721144308.1301587-1-windhl@126.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/generic/audio-graph-card.c
patch
|
blob
|
history
diff --git
a/sound/soc/generic/audio-graph-card.c
b/sound/soc/generic/audio-graph-card.c
index
2b598af
..
b327372
100644
(file)
--- a/
sound/soc/generic/audio-graph-card.c
+++ b/
sound/soc/generic/audio-graph-card.c
@@
-158,8
+158,10
@@
static int asoc_simple_parse_dai(struct device_node *ep,
* if he unbinded CPU or Codec.
*/
ret = snd_soc_get_dai_name(&args, &dlc->dai_name);
- if (ret < 0)
+ if (ret < 0) {
+ of_node_put(node);
return ret;
+ }
dlc->of_node = node;