drm/virtio: rename sync_seq and last_seq
authorGurchetan Singh <gurchetansingh@chromium.org>
Thu, 19 Nov 2020 01:08:09 +0000 (17:08 -0800)
committerGerd Hoffmann <kraxel@redhat.com>
Fri, 20 Nov 2020 09:44:41 +0000 (10:44 +0100)
To be clearer about our intentions to associate sequence numbers
and fence IDs, let's rename these variables.

Signed-off-by: Gurchetan Singh <gurchetansingh@chromium.org>
Reviewed-by: Anthoine Bourgeois <anthoine.bourgeois@gmail.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20201119010809.528-5-gurchetansingh@chromium.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
drivers/gpu/drm/virtio/virtgpu_debugfs.c
drivers/gpu/drm/virtio/virtgpu_drv.h
drivers/gpu/drm/virtio/virtgpu_fence.c

index f336a8f..5fefc88 100644 (file)
@@ -67,8 +67,8 @@ virtio_gpu_debugfs_irq_info(struct seq_file *m, void *data)
        struct virtio_gpu_device *vgdev = node->minor->dev->dev_private;
 
        seq_printf(m, "fence %llu %lld\n",
-                  (u64)atomic64_read(&vgdev->fence_drv.last_seq),
-                  vgdev->fence_drv.sync_seq);
+                  (u64)atomic64_read(&vgdev->fence_drv.last_fence_id),
+                  vgdev->fence_drv.current_fence_id);
        return 0;
 }
 
index 7c7967a..6a23255 100644 (file)
@@ -127,8 +127,8 @@ typedef void (*virtio_gpu_resp_cb)(struct virtio_gpu_device *vgdev,
                                   struct virtio_gpu_vbuffer *vbuf);
 
 struct virtio_gpu_fence_driver {
-       atomic64_t       last_seq;
-       uint64_t         sync_seq;
+       atomic64_t       last_fence_id;
+       uint64_t         current_fence_id;
        uint64_t         context;
        struct list_head fences;
        spinlock_t       lock;
index 2fe9c7e..728ca36 100644 (file)
@@ -48,7 +48,7 @@ static bool virtio_fence_signaled(struct dma_fence *f)
                /* leaked fence outside driver before completing
                 * initialization with virtio_gpu_fence_emit */
                return false;
-       if (atomic64_read(&fence->drv->last_seq) >= fence->f.seqno)
+       if (atomic64_read(&fence->drv->last_fence_id) >= fence->f.seqno)
                return true;
        return false;
 }
@@ -62,7 +62,8 @@ static void virtio_timeline_value_str(struct dma_fence *f, char *str, int size)
 {
        struct virtio_gpu_fence *fence = to_virtio_fence(f);
 
-       snprintf(str, size, "%llu", (u64)atomic64_read(&fence->drv->last_seq));
+       snprintf(str, size, "%llu",
+                (u64)atomic64_read(&fence->drv->last_fence_id));
 }
 
 static const struct dma_fence_ops virtio_fence_ops = {
@@ -100,7 +101,7 @@ void virtio_gpu_fence_emit(struct virtio_gpu_device *vgdev,
        unsigned long irq_flags;
 
        spin_lock_irqsave(&drv->lock, irq_flags);
-       fence->f.seqno = ++drv->sync_seq;
+       fence->f.seqno = ++drv->current_fence_id;
        dma_fence_get(&fence->f);
        list_add_tail(&fence->node, &drv->fences);
        spin_unlock_irqrestore(&drv->lock, irq_flags);
@@ -119,7 +120,7 @@ void virtio_gpu_fence_event_process(struct virtio_gpu_device *vgdev,
        unsigned long irq_flags;
 
        spin_lock_irqsave(&drv->lock, irq_flags);
-       atomic64_set(&vgdev->fence_drv.last_seq, fence_id);
+       atomic64_set(&vgdev->fence_drv.last_fence_id, fence_id);
        list_for_each_entry_safe(fence, tmp, &drv->fences, node) {
                if (fence_id < fence->f.seqno)
                        continue;