ARM: dts: qcom: msm8974: switch TCSR mutex to MMIO
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Tue, 20 Sep 2022 15:04:14 +0000 (17:04 +0200)
committerBjorn Andersson <andersson@kernel.org>
Mon, 17 Oct 2022 22:13:12 +0000 (17:13 -0500)
The TCSR mutex bindings allow device to be described only with address
space (so it uses MMIO, not syscon regmap).  This seems reasonable, as
TCSR mutex is actually a dedicated IO address space, and it also fixes
DT schema checks:

  qcom-msm8974-sony-xperia-rhine-amami.dtb: tcsr-mutex: 'reg' is a required property
  qcom-msm8974-sony-xperia-rhine-amami.dtb: tcsr-mutex: 'syscon' does not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Tested-by: Luca Weiss <luca@z3ntu.xyz> # fairphone-fp2
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20220920150414.637634-4-krzysztof.kozlowski@linaro.org
arch/arm/boot/dts/qcom-msm8974.dtsi

index 5ab1256..5fb09db 100644 (file)
                        resets = <&gcc GCC_MSS_RESTART>;
                        reset-names = "mss_restart";
 
-                       qcom,halt-regs = <&tcsr_mutex_block 0x1180 0x1200 0x1280>;
+                       qcom,halt-regs = <&tcsr_mutex 0x1180 0x1200 0x1280>;
 
                        qcom,smem-states = <&modem_smp2p_out 0>;
                        qcom,smem-state-names = "stop";
                        };
                };
 
-               tcsr_mutex_block: syscon@fd484000 {
-                       compatible = "syscon";
+               tcsr_mutex: hwlock@fd484000 {
+                       compatible = "qcom,msm8974-tcsr-mutex", "qcom,tcsr-mutex", "syscon";
                        reg = <0xfd484000 0x2000>;
+                       #hwlock-cells = <1>;
                };
 
                tcsr: syscon@fd4a0000 {
                };
        };
 
-       tcsr_mutex: tcsr-mutex {
-               compatible = "qcom,tcsr-mutex";
-               syscon = <&tcsr_mutex_block 0 0x80>;
-
-               #hwlock-cells = <1>;
-       };
-
        thermal-zones {
                cpu0-thermal {
                        polling-delay-passive = <250>;