ASoC: spear: Delete an error message for a failed memory allocation in two functions
authorMarkus Elfring <elfring@users.sourceforge.net>
Thu, 10 Aug 2017 07:50:51 +0000 (09:50 +0200)
committerMark Brown <broonie@kernel.org>
Thu, 10 Aug 2017 14:53:21 +0000 (15:53 +0100)
Omit an extra message for a memory allocation failure in these functions.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/spear/spdif_in.c
sound/soc/spear/spdif_out.c

index 7f32527..01b28e5 100644 (file)
@@ -216,10 +216,8 @@ static int spdif_in_probe(struct platform_device *pdev)
                return -EINVAL;
 
        host = devm_kzalloc(&pdev->dev, sizeof(*host), GFP_KERNEL);
-       if (!host) {
-               dev_warn(&pdev->dev, "kzalloc fail\n");
+       if (!host)
                return -ENOMEM;
-       }
 
        host->io_base = io_base;
        host->irq = platform_get_irq(pdev, 0);
index 0a72d52..58d5843 100644 (file)
@@ -282,10 +282,8 @@ static int spdif_out_probe(struct platform_device *pdev)
        int ret;
 
        host = devm_kzalloc(&pdev->dev, sizeof(*host), GFP_KERNEL);
-       if (!host) {
-               dev_warn(&pdev->dev, "kzalloc fail\n");
+       if (!host)
                return -ENOMEM;
-       }
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        host->io_base = devm_ioremap_resource(&pdev->dev, res);