caif_usb: Make the driver name check more efficient
authorBen Hutchings <bhutchings@solarflare.com>
Fri, 7 Dec 2012 06:20:27 +0000 (06:20 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 9 Dec 2012 05:34:02 +0000 (00:34 -0500)
Use the device model to get just the name, rather than using the
ethtool API to get all driver information.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/caif/caif_usb.c

index 582f80c..3ebc8cb 100644 (file)
@@ -128,17 +128,10 @@ static int cfusbl_device_notify(struct notifier_block *me, unsigned long what,
        struct cflayer *layer, *link_support;
        struct usbnet *usbnet;
        struct usb_device *usbdev;
-       struct ethtool_drvinfo drvinfo;
 
-       /*
-        * Quirks: High-jack ethtool to find if we have a NCM device,
-        * and find it's VID/PID.
-        */
-       if (dev->ethtool_ops == NULL || dev->ethtool_ops->get_drvinfo == NULL)
-               return 0;
-
-       dev->ethtool_ops->get_drvinfo(dev, &drvinfo);
-       if (strncmp(drvinfo.driver, "cdc_ncm", 7) != 0)
+       /* Check whether we have a NCM device, and find its VID/PID. */
+       if (!(dev->dev.parent && dev->dev.parent->driver &&
+             strcmp(dev->dev.parent->driver->name, "cdc_ncm") == 0))
                return 0;
 
        usbnet = netdev_priv(dev);