decodebin: Don't check twice if the decode chain is complete in pad_added_cb()
authorSebastian Dröge <sebastian@centricular.com>
Sat, 12 Mar 2016 17:46:44 +0000 (19:46 +0200)
committerSebastian Dröge <sebastian@centricular.com>
Mon, 14 Mar 2016 10:45:29 +0000 (12:45 +0200)
expose_pad() already does the same.

https://bugzilla.gnome.org/show_bug.cgi?id=763491

gst/playback/gstdecodebin2.c

index a3bc619..73aa258 100644 (file)
@@ -2930,18 +2930,6 @@ pad_added_cb (GstElement * element, GstPad * pad, GstDecodeChain * chain)
   if (caps)
     gst_caps_unref (caps);
 
-  EXPOSE_LOCK (dbin);
-  if (dbin->decode_chain) {
-    if (gst_decode_chain_is_complete (dbin->decode_chain)) {
-      GST_LOG_OBJECT (dbin,
-          "That was the last dynamic object, now attempting to expose the group");
-      if (!gst_decode_bin_expose (dbin))
-        GST_WARNING_OBJECT (dbin, "Couldn't expose group");
-    }
-  } else {
-    GST_DEBUG_OBJECT (dbin, "No decode chain, new pad ignored");
-  }
-  EXPOSE_UNLOCK (dbin);
   GST_PAD_STREAM_UNLOCK (pad);
 }