Fix CORS header code to be cleaner

diff --git a/atom/browser/net/js_asker.cc b/atom/browser/net/js_asker.cc
index 8f0d1d2..0e232fe 100644 (file)
--- a/atom/browser/net/js_asker.cc
+++ b/atom/browser/net/js_asker.cc
@@ -11,6 +11,8 @@
 
 namespace atom {
 
+const std::string kCorsHeader("Access-Control-Allow-Origin: *");
+
 namespace internal {
 
 namespace {

diff --git a/atom/browser/net/js_asker.h b/atom/browser/net/js_asker.h
index 8ec245e..cdc0417 100644 (file)
--- a/atom/browser/net/js_asker.h
+++ b/atom/browser/net/js_asker.h
@@ -17,6 +17,7 @@
 #include "v8/include/v8.h"
 
 namespace atom {
+extern const std::string kCorsHeader;
 
 using JavaScriptHandler =
     base::Callback<void(const net::URLRequest*, v8::Local<v8::Value>)>;

diff --git a/atom/browser/net/url_request_buffer_job.cc b/atom/browser/net/url_request_buffer_job.cc
index c4936ba..55603e7 100644 (file)
--- a/atom/browser/net/url_request_buffer_job.cc
+++ b/atom/browser/net/url_request_buffer_job.cc
@@ -50,8 +50,7 @@ void URLRequestBufferJob::GetResponseInfo(net::HttpResponseInfo* info) {
   status.append("\0\0", 2);
   net::HttpResponseHeaders* headers = new net::HttpResponseHeaders(status);
 
-  std::string cors("Access-Control-Allow-Origin: *");
-  headers->AddHeader(cors);
+  headers->AddHeader(kCorsHeader);
 
   if (!mime_type_.empty()) {
     std::string content_type_header(net::HttpRequestHeaders::kContentType);

diff --git a/atom/browser/net/url_request_string_job.cc b/atom/browser/net/url_request_string_job.cc
index 5d7a7dd..6a12026 100644 (file)
--- a/atom/browser/net/url_request_string_job.cc
+++ b/atom/browser/net/url_request_string_job.cc
@@ -32,8 +32,7 @@ void URLRequestStringJob::GetResponseInfo(net::HttpResponseInfo* info) {
   std::string status("HTTP/1.1 200 OK");
   net::HttpResponseHeaders* headers = new net::HttpResponseHeaders(status);
 
-  std::string cors("Access-Control-Allow-Origin: *");
-  headers->AddHeader(cors);
+  headers->AddHeader(kCorsHeader);
 
   if (!mime_type_.empty()) {
     std::string content_type_header(net::HttpRequestHeaders::kContentType);