projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
4e1b4d2
)
hwmon: (pwm-fan) Use dev_err_probe() to simplify error handling
author
Anson Huang
<Anson.Huang@nxp.com>
Mon, 17 Aug 2020 07:34:33 +0000
(15:34 +0800)
committer
Guenter Roeck
<linux@roeck-us.net>
Wed, 23 Sep 2020 16:42:40 +0000
(09:42 -0700)
dev_err_probe() can reduce code size, uniform error handling and record the
defer probe reason etc., use it to simplify the code.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Link:
https://lore.kernel.org/r/1597649673-22329-1-git-send-email-Anson.Huang@nxp.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/pwm-fan.c
patch
|
blob
|
history
diff --git
a/drivers/hwmon/pwm-fan.c
b/drivers/hwmon/pwm-fan.c
index
17bb642
..
bdba214
100644
(file)
--- a/
drivers/hwmon/pwm-fan.c
+++ b/
drivers/hwmon/pwm-fan.c
@@
-293,14
+293,8
@@
static int pwm_fan_probe(struct platform_device *pdev)
mutex_init(&ctx->lock);
ctx->pwm = devm_of_pwm_get(dev, dev->of_node, NULL);
- if (IS_ERR(ctx->pwm)) {
- ret = PTR_ERR(ctx->pwm);
-
- if (ret != -EPROBE_DEFER)
- dev_err(dev, "Could not get PWM: %d\n", ret);
-
- return ret;
- }
+ if (IS_ERR(ctx->pwm))
+ return dev_err_probe(dev, PTR_ERR(ctx->pwm), "Could not get PWM\n");
platform_set_drvdata(pdev, ctx);