ch_ktls: don't free skb before sending FIN

If its a last packet and fin is set. Make sure FIN is informed
to HW before skb gets freed.

Fixes: 429765a149f1 ("chcr: handle partial end part of a record")
Signed-off-by: Rohit Maheshwari <rohitm@chelsio.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c b/drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c
index bbda71b7f98bb2811e3a530ace0494c43f6898c1..a8062e038ebce640150fc5bc8c497ebad0d5bbc5 100644 (file)
--- a/drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c
+++ b/drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c
@@ -1932,6 +1932,9 @@ static int chcr_ktls_xmit(struct sk_buff *skb, struct net_device *dev)
                                                       flags);
                                goto out;
                        }
+
+                       if (th->fin)
+                               skb_get(skb);
                }
 
                if (unlikely(tls_record_is_start_marker(record))) {
@@ -2006,8 +2009,11 @@ static int chcr_ktls_xmit(struct sk_buff *skb, struct net_device *dev)
                        __skb_frag_unref(&record->frags[i]);
                }
                /* if any failure, come out from the loop. */
-               if (ret)
+               if (ret) {
+                       if (th->fin)
+                               dev_kfree_skb_any(skb);
                        return NETDEV_TX_OK;
+               }
 
                /* length should never be less than 0 */
                WARN_ON(data_len < 0);
@@ -2020,8 +2026,10 @@ static int chcr_ktls_xmit(struct sk_buff *skb, struct net_device *dev)
        /* tcp finish is set, send a separate tcp msg including all the options
         * as well.
         */
-       if (th->fin)
+       if (th->fin) {
                chcr_ktls_write_tcp_options(tx_info, skb, q, tx_info->tx_chan);
+               dev_kfree_skb_any(skb);
+       }
 
        return NETDEV_TX_OK;
 out: