scsi: be2iscsi: Add missing unlock for mbox_lock
authorJitendra Bhivare <jitendra.bhivare@broadcom.com>
Fri, 26 Aug 2016 09:39:08 +0000 (15:09 +0530)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 31 Aug 2016 02:26:15 +0000 (22:26 -0400)
Julia pointed out beiscsi_boot_get_sinfo does not unlock mbox_lock on
nonemb_cmd memory allocation failure.

Signed-off-by: Jitendra Bhivare <jitendra.bhivare@broadcom.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/be2iscsi/be_mgmt.c

index b9ff939..aebc4dd 100644 (file)
@@ -1085,8 +1085,10 @@ unsigned int beiscsi_boot_get_sinfo(struct beiscsi_hba *phba)
        nonemb_cmd->va = pci_alloc_consistent(phba->ctrl.pdev,
                                              sizeof(nonemb_cmd->size),
                                              &nonemb_cmd->dma);
-       if (!nonemb_cmd->va)
+       if (!nonemb_cmd->va) {
+               mutex_unlock(&ctrl->mbox_lock);
                return 0;
+       }
 
        req = nonemb_cmd->va;
        memset(req, 0, sizeof(*req));