drm/vboxvideo: Don't set struct drm_driver.lastclose
authorThomas Zimmermann <tzimmermann@suse.de>
Thu, 3 Nov 2022 15:14:26 +0000 (16:14 +0100)
committerThomas Zimmermann <tzimmermann@suse.de>
Sat, 5 Nov 2022 16:05:53 +0000 (17:05 +0100)
Don't set struct drm_driver.lastclose. It's used to restore the
fbdev console. But as vboxvideo uses generic fbdev emulation, the
console is being restored by the DRM client helpers already. See
the call to drm_client_dev_restore() in drm_lastclose().

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221103151446.2638-4-tzimmermann@suse.de
drivers/gpu/drm/vboxvideo/vbox_drv.c

index f4f2bd79a7cb61c90ebf6561ccc227934965d370..1cd716eb17a1c84f1b98d64608063d290d3269d2 100644 (file)
@@ -178,8 +178,6 @@ static const struct drm_driver driver = {
        .driver_features =
            DRIVER_MODESET | DRIVER_GEM | DRIVER_ATOMIC,
 
-       .lastclose = drm_fb_helper_lastclose,
-
        .fops = &vbox_fops,
        .name = DRIVER_NAME,
        .desc = DRIVER_DESC,