scsi: be2iscsi: Drop redundant pci_enable_pcie_error_reporting()
authorBjorn Helgaas <bhelgaas@google.com>
Tue, 7 Mar 2023 18:28:35 +0000 (12:28 -0600)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 10 Mar 2023 03:00:38 +0000 (22:00 -0500)
pci_enable_pcie_error_reporting() enables the device to send ERR_*
Messages.  Since commit f26e58bf6f54 ("PCI/AER: Enable error reporting when
AER is native"), the PCI core does this for all devices during enumeration,
so the driver doesn't need to do it itself.

Remove the redundant pci_enable_pcie_error_reporting() call from the
driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
from the driver .remove() path.

Note that this only controls ERR_* Messages from the device.  An ERR_*
Message may cause the Root Port to generate an interrupt, depending on the
AER Root Error Command register managed by the AER service driver.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Link: https://lore.kernel.org/r/20230307182842.870378-4-helgaas@kernel.org
Cc: Ketan Mukadam <ketan.mukadam@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/be2iscsi/be_main.c
drivers/scsi/be2iscsi/be_main.h

index 50a577ac3bb42fa06938fd3ae3845afa88866379..0aaf6fc476834847e1b6a48a8d4c3180b178259f 100644 (file)
@@ -5545,13 +5545,6 @@ static int beiscsi_dev_probe(struct pci_dev *pcidev,
                goto disable_pci;
        }
 
-       /* Enable EEH reporting */
-       ret = pci_enable_pcie_error_reporting(pcidev);
-       if (ret)
-               beiscsi_log(phba, KERN_WARNING, BEISCSI_LOG_INIT,
-                           "BM_%d : PCIe Error Reporting "
-                           "Enabling Failed\n");
-
        pci_save_state(pcidev);
 
        /* Initialize Driver configuration Paramters */
@@ -5736,7 +5729,6 @@ free_hba:
        pci_disable_msix(phba->pcidev);
        pci_dev_put(phba->pcidev);
        iscsi_host_free(phba->shost);
-       pci_disable_pcie_error_reporting(pcidev);
        pci_set_drvdata(pcidev, NULL);
 disable_pci:
        pci_release_regions(pcidev);
@@ -5779,7 +5771,6 @@ static void beiscsi_remove(struct pci_dev *pcidev)
 
        pci_dev_put(phba->pcidev);
        iscsi_host_free(phba->shost);
-       pci_disable_pcie_error_reporting(pcidev);
        pci_set_drvdata(pcidev, NULL);
        pci_release_regions(pcidev);
        pci_disable_device(pcidev);
index 98977c0700f1a1d0cc9504522aa5f1ec805c694a..71c95d1445609c73573817fbae886d2aab875b14 100644 (file)
@@ -16,7 +16,6 @@
 #include <linux/in.h>
 #include <linux/ctype.h>
 #include <linux/module.h>
-#include <linux/aer.h>
 #include <scsi/scsi.h>
 #include <scsi/scsi_cmnd.h>
 #include <scsi/scsi_device.h>