Fix SVACE Warnings

Change-Id: Ib5dd605447f78bc82fd927fd6669c559b90ea826
Signed-off-by: Kiseok Chang <kiso.chang@samsung.com>

diff --git a/setting-appmgr/src/setting-appmgr.c b/setting-appmgr/src/setting-appmgr.c
old mode 100644 (file)
new mode 100755 (executable)
index 484e1de..b9f136b
--- a/setting-appmgr/src/setting-appmgr.c
+++ b/setting-appmgr/src/setting-appmgr.c
@@ -192,6 +192,9 @@ static void _setting_appmgr_app_control_cb(app_control_h app_control,
 
                setting_view_create(ad->pkginfo_view, ad);
                setting_view_node_set_cur_view(ad->pkginfo_view);
+
+               package_info_destroy(package_info);
+
        } else {
                setting_view_node_table_register(&setting_view_appmgr_main,
                                NULL);

diff --git a/setting-license/src/setting-license-view.c b/setting-license/src/setting-license-view.c
index 0dbe363c6bdd79ce918e7688b23ba6cc9ff397c4..c00aaade7a9661e0bf0c490946db793290bf76f5 100755 (executable)
--- a/setting-license/src/setting-license-view.c
+++ b/setting-license/src/setting-license-view.c
@@ -157,17 +157,20 @@ static int readZipFile(char *zipFile, char *fileInZip)
        if (unzLocateFile(uf, fileInZip, 1)) { // try to locate file inside zip
                // second argument of unzLocateFile: 1 = case sensitive, 0 = case-insensitive
                SETTING_TRACE("File %s not found in %s", fileInZip, zipFile);
+               unzCloseCurrentFile(uf);  // close the zipfile
                return -1;
        } // file inside zip found
 
        if (unzGetCurrentFileInfo(uf, &file_info, filename_inzip, sizeof(filename_inzip), NULL, 0, NULL, 0)) {
                SETTING_TRACE("Error %d with zipfile %s in unzGetCurrentFileInfo.", err, zipFile);
+               unzCloseCurrentFile(uf);  // close the zipfile
                return -1;
        } // obtained the necessary details about file inside zip
 
        buf = (void*)malloc(size_buf); // setup buffer
        if (buf == NULL) {
                SETTING_TRACE("Error allocating memory for read buffer");
+               unzCloseCurrentFile(uf);  // close the zipfile
                return -1;
        } // buffer ready
 
@@ -175,6 +178,7 @@ static int readZipFile(char *zipFile, char *fileInZip)
        if (err != UNZ_OK) {
                SETTING_TRACE("Error %d with zipfile %s in unzOpenCurrentFilePassword.", err, zipFile);
                free(buf);
+               unzCloseCurrentFile(uf);  // close the zipfile
                return -1;
        } // file inside the zip is open
 
@@ -184,6 +188,7 @@ static int readZipFile(char *zipFile, char *fileInZip)
        if (tempfile_fp == NULL) {
                SETTING_TRACE("Error to write tempfile :  %s", tempfilename);
                free(buf);
+               unzCloseCurrentFile(uf);  // close the zipfile
                return -1;
        } // open temp file