net: dsa: lantiq: use devm_platform_ioremap_resource() to simplify code
authorYueHaibing <yuehaibing@huawei.com>
Thu, 1 Aug 2019 12:25:46 +0000 (20:25 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 1 Aug 2019 17:10:34 +0000 (13:10 -0400)
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/lantiq_gswip.c

index 4e64835..2175ec1 100644 (file)
@@ -1822,7 +1822,6 @@ remove_gphy:
 static int gswip_probe(struct platform_device *pdev)
 {
        struct gswip_priv *priv;
-       struct resource *gswip_res, *mdio_res, *mii_res;
        struct device_node *mdio_np, *gphy_fw_np;
        struct device *dev = &pdev->dev;
        int err;
@@ -1833,18 +1832,15 @@ static int gswip_probe(struct platform_device *pdev)
        if (!priv)
                return -ENOMEM;
 
-       gswip_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       priv->gswip = devm_ioremap_resource(dev, gswip_res);
+       priv->gswip = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(priv->gswip))
                return PTR_ERR(priv->gswip);
 
-       mdio_res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
-       priv->mdio = devm_ioremap_resource(dev, mdio_res);
+       priv->mdio = devm_platform_ioremap_resource(pdev, 1);
        if (IS_ERR(priv->mdio))
                return PTR_ERR(priv->mdio);
 
-       mii_res = platform_get_resource(pdev, IORESOURCE_MEM, 2);
-       priv->mii = devm_ioremap_resource(dev, mii_res);
+       priv->mii = devm_platform_ioremap_resource(pdev, 2);
        if (IS_ERR(priv->mii))
                return PTR_ERR(priv->mii);