leds: flash: Remove redundant initialization of variable ret
authorPavel Machek <pavel@ucw.cz>
Mon, 16 Aug 2021 06:47:08 +0000 (08:47 +0200)
committerPavel Machek <pavel@ucw.cz>
Mon, 16 Aug 2021 06:47:08 +0000 (08:47 +0200)
Adjust initialization not to trigger Coverity warnings.

Reported-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
drivers/leds/led-class-flash.c

index 6eeb9ef..185e170 100644 (file)
@@ -92,14 +92,12 @@ static ssize_t flash_strobe_store(struct device *dev,
        struct led_classdev *led_cdev = dev_get_drvdata(dev);
        struct led_classdev_flash *fled_cdev = lcdev_to_flcdev(led_cdev);
        unsigned long state;
-       ssize_t ret = -EINVAL;
+       ssize_t ret = -EBUSY;
 
        mutex_lock(&led_cdev->led_access);
 
-       if (led_sysfs_is_disabled(led_cdev)) {
-               ret = -EBUSY;
+       if (led_sysfs_is_disabled(led_cdev))
                goto unlock;
-       }
 
        ret = kstrtoul(buf, 10, &state);
        if (ret)