media: pci: cx25821: Replace mdelay() with msleep()

cx25821_gpio_init(), cx25821_initialize() and cx25821_registers_init()
are never called in atomic context.
They call mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

diff --git a/drivers/media/pci/cx25821/cx25821-core.c b/drivers/media/pci/cx25821/cx25821-core.c
index 040c6c2..2f01711 100644 (file)
--- a/drivers/media/pci/cx25821/cx25821-core.c
+++ b/drivers/media/pci/cx25821/cx25821-core.c
@@ -428,7 +428,7 @@ static void cx25821_registers_init(struct cx25821_dev *dev)
        tmp |= FLD_USE_ALT_PLL_REF;
        cx_write(CLK_RST, tmp & ~(FLD_VID_I_CLK_NOE | FLD_VID_J_CLK_NOE));
 
-       mdelay(100);
+       msleep(100);
 }
 
 int cx25821_sram_channel_setup(struct cx25821_dev *dev,
@@ -803,7 +803,7 @@ static void cx25821_initialize(struct cx25821_dev *dev)
        cx_write(CLK_DELAY, cx_read(CLK_DELAY) & 0x80000000);
        cx_write(PAD_CTRL, 0x12);       /* for I2C */
        cx25821_registers_init(dev);    /* init Pecos registers */
-       mdelay(100);
+       msleep(100);
 
        for (i = 0; i < VID_CHANNEL_NUM; i++) {
                cx25821_set_vip_mode(dev, dev->channels[i].sram_channels);

diff --git a/drivers/media/pci/cx25821/cx25821-gpio.c b/drivers/media/pci/cx25821/cx25821-gpio.c
index 76b8f61..f5ffaf8 100644 (file)
--- a/drivers/media/pci/cx25821/cx25821-gpio.c
+++ b/drivers/media/pci/cx25821/cx25821-gpio.c
@@ -88,7 +88,7 @@ void cx25821_gpio_init(struct cx25821_dev *dev)
        default:
                /* set GPIO 5 to select the path for Medusa/Athena */
                cx25821_set_gpiopin_logicvalue(dev, 5, 1);
-               mdelay(20);
+               msleep(20);
                break;
        }