ice: move code closer together
authorJesse Brandeburg <jesse.brandeburg@intel.com>
Thu, 8 Aug 2019 14:39:36 +0000 (07:39 -0700)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Thu, 5 Sep 2019 15:13:40 +0000 (08:13 -0700)
This is a simple patch to move the assignment to a local variable
closer to the site where the local variable is used.  This
can help readability and also maybe performance, although the
performance enhancement is really dependent upon the compiler.

No functional change.

Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/ice/ice_txrx.c

index 4fe1b33..ec581b1 100644 (file)
@@ -1068,9 +1068,6 @@ static int ice_clean_rx_irq(struct ice_ring *rx_ring, int budget)
                        continue;
                }
 
-               rx_ptype = le16_to_cpu(rx_desc->wb.ptype_flex_flags0) &
-                       ICE_RX_FLEX_DESC_PTYPE_M;
-
                stat_err_bits = BIT(ICE_RX_FLEX_DESC_STATUS0_L2TAG1P_S);
                if (ice_test_staterr(rx_desc, stat_err_bits))
                        vlan_tag = le16_to_cpu(rx_desc->wb.l2tag1);
@@ -1087,6 +1084,9 @@ static int ice_clean_rx_irq(struct ice_ring *rx_ring, int budget)
                total_rx_bytes += skb->len;
 
                /* populate checksum, VLAN, and protocol */
+               rx_ptype = le16_to_cpu(rx_desc->wb.ptype_flex_flags0) &
+                       ICE_RX_FLEX_DESC_PTYPE_M;
+
                ice_process_skb_fields(rx_ring, rx_desc, skb, rx_ptype);
 
                /* send completed skb up the stack */