ASoC: SOF: sof-audio: remove goto used for force-nocodec support
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Wed, 30 Sep 2020 15:20:25 +0000 (18:20 +0300)
committerMark Brown <broonie@kernel.org>
Mon, 26 Oct 2020 16:08:02 +0000 (16:08 +0000)
Address smatch warnings:
sound/soc/sof/sof-audio.c:375 sof_machine_check() warn: inconsistent indenting
sound/soc/sof/sof-audio.c:380 sof_machine_check() warn: ignoring unreachable code.

No functionality change.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Acked-by: Jaroslav Kysela <perex@perex.cz>
Tested-by: Jaroslav Kysela <perex@perex.cz>
Link: https://lore.kernel.org/r/20200930152026.3902186-4-kai.vehmanen@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/sof-audio.c

index afe7e50..9a8ce25 100644 (file)
@@ -443,11 +443,7 @@ int sof_machine_check(struct snd_sof_dev *sdev)
        struct snd_soc_acpi_mach *mach;
        int ret;
 
-       /* force nocodec mode */
-#if IS_ENABLED(CONFIG_SND_SOC_SOF_FORCE_NOCODEC_MODE)
-               dev_warn(sdev->dev, "Force to use nocodec mode\n");
-               goto nocodec;
-#endif
+#if !IS_ENABLED(CONFIG_SND_SOC_SOF_FORCE_NOCODEC_MODE)
 
        /* find machine */
        snd_sof_machine_select(sdev);
@@ -460,8 +456,8 @@ int sof_machine_check(struct snd_sof_dev *sdev)
        dev_err(sdev->dev, "error: no matching ASoC machine driver found - aborting probe\n");
        return -ENODEV;
 #endif
-#if IS_ENABLED(CONFIG_SND_SOC_SOF_FORCE_NOCODEC_MODE)
-nocodec:
+#else
+       dev_warn(sdev->dev, "Force to use nocodec mode\n");
 #endif
        /* select nocodec mode */
        dev_warn(sdev->dev, "Using nocodec machine driver\n");