platform/x86: intel-vbtn: Fix return value check in check_acpi_dev()
authorLu Wei <luwei32@huawei.com>
Fri, 10 Jul 2020 09:30:18 +0000 (17:30 +0800)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 14 Jul 2020 12:43:08 +0000 (15:43 +0300)
In the function check_acpi_dev(), if it fails to create
platform device, the return value is ERR_PTR() or NULL.
Thus it must use IS_ERR_OR_NULL() to check return value.

Fixes: 332e081225fc ("intel-vbtn: new driver for Intel Virtual Button")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Lu Wei <luwei32@huawei.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/platform/x86/intel-vbtn.c

index 0487b60..e85d8e5 100644 (file)
@@ -299,7 +299,7 @@ check_acpi_dev(acpi_handle handle, u32 lvl, void *context, void **rv)
                return AE_OK;
 
        if (acpi_match_device_ids(dev, ids) == 0)
-               if (acpi_create_platform_device(dev, NULL))
+               if (!IS_ERR_OR_NULL(acpi_create_platform_device(dev, NULL)))
                        dev_info(&dev->dev,
                                 "intel-vbtn: created platform device\n");